From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: cache current nsec time in struct blk_plug
Date: Tue, 16 Jan 2024 09:18:06 -0700 [thread overview]
Message-ID: <977fd9a6-cba9-4c70-940c-9a5ce0caf189@kernel.dk> (raw)
In-Reply-To: <ZaarIH6-Elu2g3rL@kbusch-mbp.dhcp.thefacebook.com>
On 1/16/24 9:13 AM, Keith Busch wrote:
> On Mon, Jan 15, 2024 at 02:53:55PM -0700, Jens Axboe wrote:
>> If the block plug gets flushed, eg on preempt or schedule out, then
>> we invalidate the cached clock.
>
> There must be something implicitly happening that I am missing. Where is
> the 'cur_time' cached clock invalidated on a plug flush?
It's not just yet, and it's also missing on preemption. I have those in
my current tree. The current test doesn't hit any of these, so it didn't
impact the testing.
--
Jens Axboe
prev parent reply other threads:[~2024-01-16 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 21:53 [PATCHSET RFC 0/2] Cache issue side time querying Jens Axboe
2024-01-15 21:53 ` [PATCH 1/2] block: add blk_time_get_ns() helper Jens Axboe
2024-01-16 6:42 ` Yu Kuai
2024-01-16 14:41 ` Jens Axboe
2024-01-15 21:53 ` [PATCH 2/2] block: cache current nsec time in struct blk_plug Jens Axboe
2024-01-16 9:51 ` Kanchan Joshi
2024-01-16 10:25 ` Johannes Thumshirn
2024-01-16 10:47 ` Kanchan Joshi
2024-01-16 14:43 ` Jens Axboe
2024-01-16 16:13 ` Keith Busch
2024-01-16 16:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=977fd9a6-cba9-4c70-940c-9a5ce0caf189@kernel.dk \
--to=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox