From: Bart Van Assche <bvanassche@acm.org>
To: Greg KH <gregkh@linuxfoundation.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, tj@kernel.org, josef@toxicpanda.com,
lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com,
yangerkun@huawei.com
Subject: Re: [PATCH RFC -next 0/7] blk-iocost: support to build iocost as kernel module
Date: Thu, 13 Jun 2024 09:15:11 -0700 [thread overview]
Message-ID: <97a2b888-4dac-451c-bb9c-40d8dc52cd60@acm.org> (raw)
In-Reply-To: <2024061342-walk-cavalier-7e48@gregkh>
On 6/12/24 10:54 PM, Greg KH wrote:
> On Thu, Jun 13, 2024 at 09:49:30AM +0800, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Yu Kuai (7):
>> kernfs: export pr_cont_kernfs_path()
>> cgroup: export cgroup_parse_float
>> block: export some API
>> blk-iocost: factor out helpers to handle params from ioc_qos_write()
>> blk-iocost: parse params before initializing iocost
>> blk-iocost: support to free iocost
>> blk-iocost: support to build iocost as kernel module
>
> No where do you say _why_ building this as a module is a good idea.
>
> Why do this at all?
With CONFIG_BLK_CGROUP_IOCOST=y (as in the Android kernel), the
blk-iocost kernel module causes a (small) runtime overhead, even if it
is not being used.
Thanks,
Bart.
next prev parent reply other threads:[~2024-06-13 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 1:49 [PATCH RFC -next 0/7] blk-iocost: support to build iocost as kernel module Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 1/7] kernfs: export pr_cont_kernfs_path() Yu Kuai
2024-06-13 5:55 ` Greg KH
2024-06-13 6:55 ` Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 2/7] cgroup: export cgroup_parse_float Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 3/7] block: export some API Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 4/7] blk-iocost: factor out helpers to handle params from ioc_qos_write() Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 5/7] blk-iocost: parse params before initializing iocost Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 6/7] blk-iocost: support to free iocost Yu Kuai
2024-06-13 1:49 ` [PATCH RFC -next 7/7] blk-iocost: support to build iocost as kernel module Yu Kuai
2024-06-13 5:54 ` Greg KH
2024-06-13 5:54 ` [PATCH RFC -next 0/7] " Greg KH
2024-06-13 6:53 ` Yu Kuai
2024-06-13 16:15 ` Bart Van Assche [this message]
2024-06-14 1:07 ` Yu Kuai
2024-06-14 5:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a2b888-4dac-451c-bb9c-40d8dc52cd60@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).