From: Jens Axboe <axboe@kernel.dk>
To: Paolo Valente <paolo.valente@linaro.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"tj@kernel.org" <tj@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
Bart Van Assche <bart.vanassche@sandisk.com>
Subject: Re: [WIP BRANCH] cgroups support in bfq-mq WIP branch
Date: Sat, 25 Feb 2017 11:52:40 -0700 [thread overview]
Message-ID: <97eadcb9-5049-399a-e5a7-d4f8b821756b@kernel.dk> (raw)
In-Reply-To: <CBE2870C-EEB4-4C2E-A5A3-20C37E16B6AE@linaro.org>
On 02/25/2017 10:44 AM, Paolo Valente wrote:
> Hi,
> I've just completed cgroups support, and I'd like to highlight the
> main blk-mq issue that I have found along the way. I have pushed the
> commit that completes the support for cgroups to the usual WIP branch
> [1]. Before moving to this issue, I have preliminary question about
> the scheduler name, since I'm about to start preparing the patch
> series for submission. So far, I have used bfq-mq as a temporary
> name. Are we fine with it, or should I change it, for example, to
> just bfq? Jens?
Just call it 'bfq', that doesn't conflict with anything that's
in the kernel already.
> I've found a sort of circular dependency in blk-mq, related to
> scheduler initialization. To describe both the issue and how I've
> addressed it, I'm pasting the message of the new commit.
Rebase your patches on top of Linus current master, some of them
will need to change and some can be dropped.
And disentangle it completely from the old bfq, I don't want to see
nasty stuff like includes of .c files with prior defines modifying
behavior of functions.
When that's done, get it posted for review asap. I would imagine
we will go through a few postings and review cycles, and if we're
targeting 4.12 with this, then we should get the ball rolling
on that side.
--
Jens Axboe
next prev parent reply other threads:[~2017-02-25 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 17:44 [WIP BRANCH] cgroups support in bfq-mq WIP branch Paolo Valente
2017-02-25 18:52 ` Jens Axboe [this message]
2017-03-02 10:15 ` Paolo Valente
2017-03-02 15:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97eadcb9-5049-399a-e5a7-d4f8b821756b@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox