From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Keith Busch <kbusch@meta.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2] block: rename min_segment_size
Date: Mon, 20 Oct 2025 23:28:00 +0000 [thread overview]
Message-ID: <995806f3-c875-4c8a-af5b-68c05822495c@nvidia.com> (raw)
In-Reply-To: <20251020204715.3664483-1-kbusch@meta.com>
On 10/20/25 13:47, Keith Busch wrote:
> From: Keith Busch<kbusch@kernel.org>
>
> Despite its name, the block layer is fine with segments smaller that the
> "min_segment_size" limit. The value is an optimization limit indicating
> the largest segment that can be used without considering boundary
> limits. Smaller segments can take a fast path, so give it a name that
> reflects that: max_fast_segment_size.
>
> Signed-off-by: Keith Busch<kbusch@kernel.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-10-20 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 20:47 [PATCHv2] block: rename min_segment_size Keith Busch
2025-10-20 23:28 ` Chaitanya Kulkarni [this message]
2025-10-21 1:45 ` Ming Lei
2025-10-21 2:22 ` Martin K. Petersen
2025-10-22 6:11 ` Christoph Hellwig
2025-10-22 13:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995806f3-c875-4c8a-af5b-68c05822495c@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox