From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org
Subject: Re: avoid calling nth_page in the block I/O path v2
Date: Fri, 12 Apr 2019 09:15:06 -0600 [thread overview]
Message-ID: <9a5a3a14-0438-2a31-661f-02fcb16dc767@kernel.dk> (raw)
In-Reply-To: <20190411062331.27800-1-hch@lst.de>
On 4/11/19 12:23 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> you complained about the overhead of calling nth_page in the multipage
> bio_vec enabled I/O path a while ago. While I can't really reproduce
> the numbers on my (slower) hardware we could avoid the nth_page calls
> pretty easily with a few tweaks. Can you take a look at this series?
>
> Changes since v1:
> - remove a spurious variable initialization
Applied for 5.2, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-04-12 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 6:23 avoid calling nth_page in the block I/O path v2 Christoph Hellwig
2019-04-11 6:23 ` [PATCH 1/5] block: rewrite blk_bvec_map_sg to avoid a nth_page call Christoph Hellwig
2019-04-11 6:23 ` [PATCH 2/5] block: refactor __bio_iov_bvec_add_pages Christoph Hellwig
2019-04-11 7:10 ` Ming Lei
2019-04-11 6:23 ` [PATCH 3/5] block: don't allow multiple bio_iov_iter_get_pages calls per bio Christoph Hellwig
2019-04-11 7:31 ` Ming Lei
2019-04-12 15:03 ` Bart Van Assche
2019-04-11 6:23 ` [PATCH 4/5] block: change how we get page references in bio_iov_iter_get_pages Christoph Hellwig
2019-04-11 7:36 ` Ming Lei
2019-04-11 6:23 ` [PATCH 5/5] block: only allow contiguous page structs in a bio_vec Christoph Hellwig
2019-04-12 15:15 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5a3a14-0438-2a31-661f-02fcb16dc767@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox