Linux block layer
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@aol.com>
To: Christoph Hellwig <hch@infradead.org>, Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-block@vger.kernel.org,
	"linux-erofs@lists.ozlabs.org" <linux-erofs@lists.ozlabs.org>
Subject: Re: Some new bio merging behaviors in __bio_try_merge_page
Date: Fri, 12 Apr 2019 00:25:19 +0800	[thread overview]
Message-ID: <9aa607da-6ccb-8166-22df-735a3b127f2e@aol.com> (raw)
In-Reply-To: <20190411153411.GA16987@infradead.org>



On 2019/4/11 23:34, Christoph Hellwig wrote:
> On Thu, Apr 11, 2019 at 04:09:54PM +0800, Ming Lei wrote:
>> I don't think it is a good behaviour to use bio->bi_max_vecs to limit
>> max allowed page, you may see the idea from the naming simply...
>>
>> If there were other such drivers, we may fix it easily, and the following
>> patch should fix your issue:
> 
> Yep.  Consumers of the block layer really have no business at all
> looking at bi_vcnt.

Thanks for pointing out, Ming's solution is enough to solve erofs issue.

Thanks,
Gao XIang

> 

      reply	other threads:[~2019-04-11 16:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11  5:47 Some new bio merging behaviors in __bio_try_merge_page Gao Xiang
2019-04-11  7:08 ` Ming Lei
2019-04-11  7:43   ` Gao Xiang
2019-04-11  8:09     ` Ming Lei
2019-04-11 10:20       ` Gao Xiang
2019-04-11 15:34       ` Christoph Hellwig
2019-04-11 16:25         ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aa607da-6ccb-8166-22df-735a3b127f2e@aol.com \
    --to=hsiangkao@aol.com \
    --cc=axboe@kernel.dk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox