From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70051EB64DD for ; Thu, 15 Jun 2023 08:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237793AbjFOI0B (ORCPT ); Thu, 15 Jun 2023 04:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239107AbjFOIZ7 (ORCPT ); Thu, 15 Jun 2023 04:25:59 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DE651FC7; Thu, 15 Jun 2023 01:25:58 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B71AC21A0F; Thu, 15 Jun 2023 08:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686817556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wgkjDVpb9Q3rShRwIWWsbklcvqvaFaWvAQilrKNG3g4=; b=hbzVPgp6qwE3jOOBBs4elxe/sa5FZYfJnkdG2Mea+6m9RgP3pjC9dfeqNWYjG9qOCzPIrs UlUr2XQlBuLeWXyzmkZpEpde/0ehbIdAUwBve0WlgAijmlH37PNjrJp6YJRi3eeERwhF7G gfeLeHZPYFw9Mw2+T80+ed1EQBhTOME= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686817556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wgkjDVpb9Q3rShRwIWWsbklcvqvaFaWvAQilrKNG3g4=; b=v9kA4dpxToICssRZ2A4wsaKRJbe5dZ3ppvFfd0HArvtsZBBNsZ2BljbT+fUQtnfSAbNVK+ kdowtIkMjmLGX3DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A92BA13467; Thu, 15 Jun 2023 08:25:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lQvlJxTLimSULwAAMHmgww (envelope-from ); Thu, 15 Jun 2023 08:25:56 +0000 Message-ID: <9bcbd519-9c93-1f3b-d309-b46973c9d138@suse.de> Date: Thu, 15 Jun 2023 10:25:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 08/11] md-bitmap: account for mddev->bitmap_info.offset in read_sb_page Content-Language: en-US To: Christoph Hellwig , Song Liu Cc: linux-raid@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20230615064840.629492-1-hch@lst.de> <20230615064840.629492-9-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230615064840.629492-9-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 6/15/23 08:48, Christoph Hellwig wrote: > Diretly apply mddev->bitmap_info.offset to the sector number to read > instead of doing that in both callers. > > Signed-off-by: Christoph Hellwig > --- > drivers/md/md-bitmap.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes