From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-block@vger.kernel.org, Shaun Tancheff <shaun@tancheff.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 0/2] Rename blk_queue_zone_size and bdev_zone_size
Date: Thu, 12 Jan 2017 13:49:17 -0700 [thread overview]
Message-ID: <9cdcae8c-ad41-bd22-1e0d-0facdae52a71@kernel.dk> (raw)
In-Reply-To: <36f3cd82-93f3-06ce-df75-f3c7d98322c3@kernel.dk>
On 01/11/2017 09:38 PM, Jens Axboe wrote:
> On 01/11/2017 09:36 PM, Damien Le Moal wrote:
>> Jens,
>>
>> On 1/12/17 12:52, Jens Axboe wrote:
>>> On Thu, Jan 12 2017, Damien Le Moal wrote:
>>>> All block device data fields and functions returning a number of 512B
>>>> sectors are by convention named xxx_sectors while names in the form
>>>> of xxx_size are generally used for a number of bytes. The blk_queue_zone_size
>>>> and bdev_zone_size functions were not following this convention so rename
>>>> them.
>>>>
>>>> This is a style fix and no functional change is introduced by this patch.
>>>
>>> I agree, this cleans it up. Applied.
>>
>> Thank you. I saw that you applied to for-4.11/block. Could we get these
>> in applied to 4.10-rc so that the zoned block device API is cleaner from
>> the first stable release of that API?
>
> Sure, I did consider that as well. Since I just pushed out the 4.11
> branch, I'll rebase and yank these into the 4.10 branch instead.
Just in case you missed it, I had to fold your two patches. Looking at
it again, what is going on? You rename a function, and then patch #2
renames the use of that function in a different spot? How did that ever
pass your testing? For something intended for the current series, please
be more careful than that, that's just sloppy.
--
Jens Axboe
next prev parent reply other threads:[~2017-01-12 20:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 2:42 [PATCH 0/2] Rename blk_queue_zone_size and bdev_zone_size Damien Le Moal
2017-01-12 2:42 ` [PATCH 1/2] block: " Damien Le Moal
2017-01-12 2:42 ` [PATCH 2/2] f2fs: Rename bdev_zone_size to bdev_zone_sectors Damien Le Moal
2017-01-12 3:52 ` [PATCH 0/2] Rename blk_queue_zone_size and bdev_zone_size Jens Axboe
2017-01-12 4:36 ` Damien Le Moal
2017-01-12 4:38 ` Jens Axboe
2017-01-12 4:43 ` Damien Le Moal
2017-01-12 20:49 ` Jens Axboe [this message]
2017-01-13 0:10 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdcae8c-ad41-bd22-1e0d-0facdae52a71@kernel.dk \
--to=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=shaun@tancheff.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox