public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Keith Busch <kbusch@kernel.org>,
	linux-block@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org
Subject: Re: [GIT PULL] nvme fixes for Linux 5.16
Date: Thu, 25 Nov 2021 08:59:57 -0700	[thread overview]
Message-ID: <9d933bfa-eeec-2b9a-ab91-aa1140a41f62@kernel.dk> (raw)
In-Reply-To: <YZ+mI9a1Jd2/zNkh@infradead.org>

On 11/25/21 8:05 AM, Christoph Hellwig wrote:
> On Thu, Nov 25, 2021 at 07:55:38AM -0700, Jens Axboe wrote:
>> On 11/25/21 7:04 AM, Christoph Hellwig wrote:
>>>  drivers/nvme/host/core.c          | 29 +++++++++++++++++--
>>>  drivers/nvme/host/fabrics.c       |  3 ++
>>>  drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++--------------------
>>>  drivers/nvme/target/io-cmd-file.c |  2 ++
>>>  drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++--------
>>>  5 files changed, 93 insertions(+), 46 deletions(-)
>>
>> This doesn't match what I get:
>>
>>  drivers/nvme/host/core.c          | 29 +++++++++++++++++++---
>>  drivers/nvme/host/fabrics.c       |  3 +++
>>  drivers/nvme/host/tcp.c           | 61 +++++++++++++++++++++++-----------------------
>>  drivers/nvme/target/io-cmd-file.c |  4 ++-
>>  drivers/nvme/target/tcp.c         | 44 ++++++++++++++++++++++++---------
>>  5 files changed, 94 insertions(+), 47 deletions(-)
>>
>> Hmm?
> 
> Looks like the diffstt doesn't include the the requested reformatting
> in io-cmd-file.c.  But I have no idea why.

Funky... I pulled it and pushed it out, just double check if it looks
consistent with what you expect.

-- 
Jens Axboe


  reply	other threads:[~2021-11-25 16:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 14:04 [GIT PULL] nvme fixes for Linux 5.16 Christoph Hellwig
2021-11-25 14:55 ` Jens Axboe
2021-11-25 15:05   ` Christoph Hellwig
2021-11-25 15:59     ` Jens Axboe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-12-10  6:15 Christoph Hellwig
2021-12-10 13:44 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d933bfa-eeec-2b9a-ab91-aa1140a41f62@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox