Re: remove another host aware model leftover

[Damien Le Moal <dlemoal@kernel.org>]

On 12/29/23 02:14, Christoph Hellwig wrote:
> On Thu, Dec 28, 2023 at 05:45:29PM +0900, Damien Le Moal wrote:
>> On 12/28/23 16:51, Christoph Hellwig wrote:
>>> Hi all,
>>>
>>> now that support for the host aware zoned model is gone in the
>>> for-6.8/block branch, there is no way the sd driver can find a device
>>> where is has to clear the zoned flag, and we can thus remove the code
>>> for it, including a block layer helper.
>>
>> Hmmm... There is one case: if the user uses a passthrough command to issue a
>> FORMAT WITH PRESET command to reformat the disk from SMR to CMR or from CMR to
>> SMR. The next revalidate will see a different device type in this case, and
>> SMR-to-CMR reformat will need clearing the zoned stuff.
> 
> scsi_device.type is only set in scsi_add_lun and thus can't change without
> a re-probe of the upper level driver.

OK. I was worried about what might happen with libata/libsas drives, but
checking the code, ata_dev_same_device() throws an error from ata_reread_id() if
the device class (device type) changes. So that will force the user to do a full
rescan for this corner case. I think we are OK.

Feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

for the series.

-- 
Damien Le Moal
Western Digital Research