From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B5518EB0 for ; Sat, 15 Mar 2025 16:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742057234; cv=none; b=Hlto0LqJpHErvz1hNBAzLfFzmD4ftoUrQnEd6upeWIaOptMG9kiMOeOzyzi+dnN4IZoeyAAN0YRGqFHNHXUpryda6zzcZAp5mATH9WgCb13FtqShJmZI6EMt4EoZJKO4KIDrucrK5p3RvC5g4Q66n26BKEvkQEyzr73RvZ2AvW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742057234; c=relaxed/simple; bh=RzHWaT4y8FPuXSb9EybUcX/aTXlFTIG+ZECIl1glCDs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t5efdd6+1ab/V6jfnyjwARRUF5p54BEukypO5kLHI2ZhetyeADqH2Zy6j4jH+5hiUm/ORYQkCIunyM4F9hxKv9YpX4aERC8b2xwUyWYs0UHRmJP5PYzEU5kSR5tpu6Ds9BAZNNVxPS4Km5GKCcG4W/o1aXG1DZL0EMBbW2Vvy68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=NezbWjHJ; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="NezbWjHJ" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-85b5e49615aso306119439f.1 for ; Sat, 15 Mar 2025 09:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1742057231; x=1742662031; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RvVjMW0xlIRW+xAq0tG5On8FqH6hGpEXfAg7HOXwb2o=; b=NezbWjHJWogCb+zWyAdo2X381DaXgKolfJvDEb8zZqsIOoEq9DzU5aQ1iUCzVj43US Mi6gCU2K27H9SVnXImmqcAQFKwn6nRTfpcs9nlNIGKf4L2D7qBPHsMXV/ESJa91aIX5q zwCNOHlFQFsH6yEbwMvXZL5a+tzF7o8/pcJp3QvNQTMcbF4j7Qj7kP5JK1JXHrz4h/bW WFpCL9mfNaSWzmdMMLP9y3CYLD+KsFBszYm0Yi+o0TgymxImGZNxCJbw89tF8DxkD3te e0cL34wbXjIBJDlK60DVVjQbeUEjFApw4j5od7A9dIK/l7pAlcC1/kuTATzbSapcOUVd xx+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742057231; x=1742662031; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RvVjMW0xlIRW+xAq0tG5On8FqH6hGpEXfAg7HOXwb2o=; b=lyoMNSsOdKPBcY5yb9Fs/6m+BUzAZI4DNLKzlP8Cl7souWJdH5SuTIqNIpL8rPa7wl eEiIpJiuLUPUgqFA9Y9r/EMP2MfcRQO1msIlAdOAFcdYSJ0moqJTAwX7+ogawu8UIWNZ dxmDiPiU2UVo4H1IcTH3m3Xt58F1PnEtGpHNB6th4uj/BY+ooW1J5N4ma3+WAq/ern05 JeZMCtRqupiPR+80iE2v9Sbc5zM0eyRd2Bxw5qAt/2HPsOdljzgBvbAAGHsBiUxWlKd8 HTSmhOQEJhsvNBkD0gha75TMagcquMgX2oAAa8WEt0csfYnYsrMSb4EnxH9wPfZyY9rB nkaw== X-Gm-Message-State: AOJu0YzVPBLzWXCkHZGsHZVj9Ekgi+ESKzSgHE+79QusdmrvbspDTXDU IAiEIDLNNgtuXz+NQmKyRCBD8YroDNqbQdkTfPdgGmaf+V46laon6qu654VDOrU= X-Gm-Gg: ASbGnctdbU/INnEda21mhXY2x3Xqw5NInl1CX6I1GH2FI2/yyLrV9ZZFe5D95B/fLGM xPrV4plvjlHyZwQ4BTc6FO0v8IQyJiOMZRUj8rnggpeV3rz2u8J/efUpyfyVQ2OdXwLY2B6PAuA GodzeDMIeVWqTb7qj1SMyLcFciHee5jywLZSFLqaJZSn3353gOv0lSbKZDk2NQbhI4HFbTAioQL 0HzshK0l9kYIqwdW6ShQ3buT0CfpsfFZZjr5DP8pYvIQrVDtKk4zURzfO0POcc1kP+fq/Tx9nSd PKx2m0zX8JrezAMOPTWQowBiaO2JkoXz3nxUcMUaeQ== X-Google-Smtp-Source: AGHT+IHOOeiIQZQPOu8/OVyhd4PFH31ke+riSoGFw34JBk8pbMYH6OQSgnRrTi5e/eP9N2SBosxEdw== X-Received: by 2002:a05:6602:3a0c:b0:85b:5d92:35b9 with SMTP id ca18e2360f4ac-85dc47d6010mr680553339f.2.1742057231114; Sat, 15 Mar 2025 09:47:11 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f2637fb2b2sm1404595173.94.2025.03.15.09.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Mar 2025 09:47:10 -0700 (PDT) Message-ID: <9db17620-4b93-4c01-b7f8-ecab83b12d0f@kernel.dk> Date: Sat, 15 Mar 2025 10:47:09 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/14] block: Allow REQ_FUA|REQ_READ To: Kent Overstreet , linux-bcachefs@vger.kernel.org Cc: linux-block@vger.kernel.org References: <20250311201518.3573009-1-kent.overstreet@linux.dev> <20250311201518.3573009-14-kent.overstreet@linux.dev> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250311201518.3573009-14-kent.overstreet@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/11/25 2:15 PM, Kent Overstreet wrote: > REQ_FUA|REQ_READ means "do a read that bypasses the controller cache", > the same as writes. > > This is useful for when the filesystem gets a checksum error, it's > possible that a bit was flipped in the controller cache, and when we > retry we want to retry the entire IO, not just from cache. > > The nvme driver already passes through REQ_FUA for reads, not just > writes, so disabling the warning is sufficient to start using it, and > bcachefs is implementing additional retries for checksum errors so can > immediately use it. This one got effectively nak'ed by various folks here: > Link: https://lore.kernel.org/linux-block/20250311133517.3095878-1-kent.overstreet@linux.dev/ yet it's part of this series and in linux-next? Hmm? -- Jens Axboe