From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: Bart Van Assche <bart.vanassche@wdc.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: use mutex_trylock to avoid lock inversion
Date: Thu, 28 Jun 2018 09:15:32 +0800 [thread overview]
Message-ID: <9ee9aee0-9361-b2ef-3124-aa6cab678faf@oracle.com> (raw)
In-Reply-To: <07e9e71a-723c-93a8-becb-df5d2f43b690@oracle.com>
On 06/28/2018 09:11 AM, jianchao.wang wrote:
> Hi Bart
>
> On 06/26/2018 11:36 PM, Bart Van Assche wrote:
>> On 06/25/18 20:47, jianchao.wang wrote:
>>> V2 patch has been posted, would you please take a look at on them ?
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__marc.info_-3Fl-3Dlinux-2Dblock-26m-3D152965143412927-26w-3D2&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=7WdAxUBeiTUTCy8v-7zXyr4qk7sx26ATvfo6QSTvZyQ&m=FPLHVLVF0V8ZCvwZJx7vHy9v01iAQogJ_IbvseGhElo&s=tQ0ZiK7VrV4j-6K_WEfiWAyxogOrC8hOm6coS9nAmYI&e=
>>
>> Hello Jianchao,
>>
>> Patches 1/3 and 2/3 of that series look fine to me but I don't like the approach of patch 3/3 so please do not expect a review from me for that patch.
>>
>
> Would you please explain the defects of the patch 3/3 ?
We still need some way to serialize the blk_register/unregister_queue, blk_mq_sysfs_register/unregister and sysfs queue, mq, hctx entries' show and store method. So I didn't introduce another mutex as your suggestions.
>
> Thanks
> Jianchao
>
prev parent reply other threads:[~2018-06-28 1:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 7:00 [PATCH] blk-mq: use mutex_trylock to avoid lock inversion Jianchao Wang
2018-06-19 15:20 ` Bart Van Assche
2018-06-20 2:09 ` jianchao.wang
2018-06-20 16:18 ` Bart Van Assche
2018-06-21 8:23 ` jianchao.wang
2018-06-26 3:46 ` jianchao.wang
2018-06-26 15:36 ` Bart Van Assche
2018-06-28 1:11 ` jianchao.wang
2018-06-28 1:15 ` jianchao.wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ee9aee0-9361-b2ef-3124-aa6cab678faf@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox