From: Markus Elfring <Markus.Elfring@web.de>
To: Li Chen <chenl311@chinatelecom.cn>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: Li Chen <me@linux.beauty>, LKML <linux-kernel@vger.kernel.org>,
Yang Erkun <yangerkun@huawei.com>
Subject: Re: [PATCH] loop: fix backing file reference leak on validation error
Date: Sun, 28 Sep 2025 15:48:23 +0200 [thread overview]
Message-ID: <9f6acb84-02cb-4f76-bf37-e79b87157f1e@web.de> (raw)
In-Reply-To: <20250926121231.32549-1-me@linux.beauty>
…
> Fix this by calling fput(file) before returning the error.
…
> +++ b/drivers/block/loop.c
…
How do you think about to increase the application of scope-based resource management?
https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/file.h#L97
Regards,
Markus
next prev parent reply other threads:[~2025-09-28 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 12:12 [PATCH] loop: fix backing file reference leak on validation error Li Chen
2025-09-28 1:54 ` yangerkun
2025-09-29 12:54 ` Li Chen
2025-09-28 13:48 ` Markus Elfring [this message]
2025-09-29 12:53 ` Li Chen
2025-09-29 15:01 ` Ming Lei
2025-09-30 0:05 ` Li Chen
2025-09-29 1:11 ` Yu Kuai
2025-09-29 12:56 ` Li Chen
2025-09-29 5:14 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f6acb84-02cb-4f76-bf37-e79b87157f1e@web.de \
--to=markus.elfring@web.de \
--cc=axboe@kernel.dk \
--cc=chenl311@chinatelecom.cn \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@linux.beauty \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox