[PATCH 0/3] block: m68k: add missing MODULE_DESCRIPTION() macros

[PATCH 0/3] block: m68k: add missing MODULE_DESCRIPTION() macros

[Jeff Johnson]

With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o

Since these have traditionally had different commit prefixes, I
submitted individual patches. Let me know if you want me to squash
them.

In addition, drivers/block/swim3.c is also missing a
MODULE_DESCRIPTION(), but I haven't yet actually triggered the
warning. I need to customize a PPC configuration which enables
MAC_FLOPPY in order to trigger the warning and verify the fix.

I'll get around to that when I finish the remaining m68k issues.

---
Jeff Johnson (3):
      amiflop: add missing MODULE_DESCRIPTION() macro
      ataflop: add missing MODULE_DESCRIPTION() macro
      z2ram: add missing MODULE_DESCRIPTION() macro

 drivers/block/amiflop.c | 1 +
 drivers/block/ataflop.c | 1 +
 drivers/block/z2ram.c   | 1 +
 3 files changed, 3 insertions(+)
---
base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
change-id: 20240617-md-m68k-drivers-block-46c301b46f49

[PATCH 1/3] amiflop: add missing MODULE_DESCRIPTION() macro

[Jeff Johnson]

With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/block/amiflop.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index a25414228e47..310254c994aa 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -232,6 +232,7 @@ static DEFINE_MUTEX(amiflop_mutex);
 static unsigned long int fd_def_df0 = FD_DD_3;     /* default for df0 if it doesn't identify */
 
 module_param(fd_def_df0, ulong, 0);
+MODULE_DESCRIPTION("Amiga floppy driver");
 MODULE_LICENSE("GPL");
 
 /*

-- 
2.42.0

Re: [PATCH 1/3] amiflop: add missing MODULE_DESCRIPTION() macro

[Geert Uytterhoeven]

On Tue, Jun 18, 2024 at 3:14 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 2/3] ataflop: add missing MODULE_DESCRIPTION() macro

[Jeff Johnson]

With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/block/ataflop.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
index cacc4ba942a8..b19884da4376 100644
--- a/drivers/block/ataflop.c
+++ b/drivers/block/ataflop.c
@@ -2197,4 +2197,5 @@ static void __exit atari_floppy_exit(void)
 module_init(atari_floppy_init)
 module_exit(atari_floppy_exit)
 
+MODULE_DESCRIPTION("Atari floppy driver");
 MODULE_LICENSE("GPL");

-- 
2.42.0

Re: [PATCH 2/3] ataflop: add missing MODULE_DESCRIPTION() macro

[Geert Uytterhoeven]

On Tue, Jun 18, 2024 at 3:14 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 3/3] z2ram: add missing MODULE_DESCRIPTION() macro

[Jeff Johnson]

With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
 drivers/block/z2ram.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c
index 7c5f4e4d9b50..4b7219be1bb8 100644
--- a/drivers/block/z2ram.c
+++ b/drivers/block/z2ram.c
@@ -409,4 +409,5 @@ static void __exit z2_exit(void)
 
 module_init(z2_init);
 module_exit(z2_exit);
+MODULE_DESCRIPTION("Amiga Zorro II ramdisk driver");
 MODULE_LICENSE("GPL");

-- 
2.42.0

Re: [PATCH 3/3] z2ram: add missing MODULE_DESCRIPTION() macro

[Geert Uytterhoeven]

On Tue, Jun 18, 2024 at 3:15 AM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/3] block: m68k: add missing MODULE_DESCRIPTION() macros

[Chaitanya Kulkarni]

On 6/17/24 18:13, Jeff Johnson wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o
>
> Since these have traditionally had different commit prefixes, I
> submitted individual patches. Let me know if you want me to squash
> them.
>
> In addition, drivers/block/swim3.c is also missing a
> MODULE_DESCRIPTION(), but I haven't yet actually triggered the
> warning. I need to customize a PPC configuration which enables
> MAC_FLOPPY in order to trigger the warning and verify the fix.
>
> I'll get around to that when I finish the remaining m68k issues.
>
> ---
> Jeff Johnson (3):
>        amiflop: add missing MODULE_DESCRIPTION() macro
>        ataflop: add missing MODULE_DESCRIPTION() macro
>        z2ram: add missing MODULE_DESCRIPTION() macro
>
>   drivers/block/amiflop.c | 1 +
>   drivers/block/ataflop.c | 1 +
>   drivers/block/z2ram.c   | 1 +
>   3 files changed, 3 insertions(+)
> ---
> base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
> change-id: 20240617-md-m68k-drivers-block-46c301b46f49
>
>

For the series, looks good ...

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH 0/3] block: m68k: add missing MODULE_DESCRIPTION() macros

[Jens Axboe]

On Mon, 17 Jun 2024 18:13:31 -0700, Jeff Johnson wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o
> 
> Since these have traditionally had different commit prefixes, I
> submitted individual patches. Let me know if you want me to squash
> them.
> 
> [...]

Applied, thanks!

[1/3] amiflop: add missing MODULE_DESCRIPTION() macro
      commit: 28d8c13830cc530996157e22ecf22def90cb7f35
[2/3] ataflop: add missing MODULE_DESCRIPTION() macro
      commit: ba8df22e25e7e906254f4f490d7bcfbe637152aa
[3/3] z2ram: add missing MODULE_DESCRIPTION() macro
      commit: 465478bb00168a7620788990b1679c5067d421f2

Best regards,
-- 
Jens Axboe