From: Dan Williams <dan.j.williams@intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jens Axboe <axboe@fb.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH] brd: fix brd_rw_page() vs copy_to_brd_setup errors
Date: Wed, 26 Jul 2017 14:42:58 -0700 [thread overview]
Message-ID: <CAPcyv4hyKU4X6OVVn2weKz8h-7v0FKXuxt5MTesDVjzdrg1M9Q@mail.gmail.com> (raw)
In-Reply-To: <20170726213214.GA25525@linux.intel.com>
On Wed, Jul 26, 2017 at 2:32 PM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:
> On Wed, Jul 26, 2017 at 01:12:28PM -0700, Christoph Hellwig wrote:
>> On Tue, Jul 25, 2017 at 06:02:29PM -0700, Dan Williams wrote:
>> > As is done in zram_rw_page, pmem_rw_page, and btt_rw_page, don't
>> > call page_endio in the error case since do_mpage_readpage and
>> > __mpage_writepage will resubmit on error. Calling page_endio in the
>> > error case leads to double completion.
>> >
>> > Cc: Jens Axboe <axboe@kernel.dk>
>> > Cc: Matthew Wilcox <mawilcox@microsoft.com>
>> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
>> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>> > ---
>> > Noticed this while looking at unrelated brd code...
>>
>> And the real question would be: where would we see any real life impact
>> of just removing brd_rw_page?
>
> I've got patches ready that remove rw_page from brd, btt and pmem. I'll send
> out once I'm done regression testing.
That would leave zram_rw_page(), is there a compelling reason to keep
that and the related infrastructure?
prev parent reply other threads:[~2017-07-26 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 1:02 [PATCH] brd: fix brd_rw_page() vs copy_to_brd_setup errors Dan Williams
2017-07-26 20:12 ` Christoph Hellwig
2017-07-26 21:32 ` Ross Zwisler
2017-07-26 21:42 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hyKU4X6OVVn2weKz8h-7v0FKXuxt5MTesDVjzdrg1M9Q@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).