From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: Daniel Wagner <dwagner@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Logan Gunthorpe <logang@deltatee.com>,
Omar Sandoval <osandov@fb.com>
Subject: RE: [PATCH blktests v1 2/2] nmve/018: Reword misleading error message
Date: Tue, 28 Jan 2020 19:27:50 +0000 [thread overview]
Message-ID: <CS1PR8401MB1237A6FBBBA1436C93F89B78AB0A0@CS1PR8401MB1237.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200128084434.128750-3-dwagner@suse.de>
> -----Original Message-----
> From: linux-block-owner@vger.kernel.org <linux-block-
> owner@vger.kernel.org> On Behalf Of Daniel Wagner
> Sent: Tuesday, January 28, 2020 2:45 AM
> Subject: [PATCH blktests v1 2/2] nmve/018: Reword misleading error message
>
> 'nvme read' is expected to fail, though the error message "ERROR:
> Successfully..." is misleading. Reword the error text to clarify the
> real indent of the test and what failed.
intent
>
> Reported-by: Logan Gunthorpe <logang@deltatee.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
...
> - && echo "ERROR: Successfully read out of device lba range"
> + && echo "ERROR: nvme read was successful for out of range lba"
>
To avoid being picked up by a grep for "success", you could use:
ERROR: nvme read for out of range LBA was not rejected
next prev parent reply other threads:[~2020-01-28 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 8:44 [PATCH blktests v1 0/2] nmve/018 fixes Daniel Wagner
2020-01-28 8:44 ` [PATCH blktests v1 1/2] nvme/018: Ignore message generated by nvme read Daniel Wagner
2020-01-28 8:44 ` [PATCH blktests v1 2/2] nmve/018: Reword misleading error message Daniel Wagner
2020-01-28 19:27 ` Elliott, Robert (Servers) [this message]
2020-01-28 16:46 ` [PATCH blktests v1 0/2] nmve/018 fixes Logan Gunthorpe
2020-01-30 0:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1237A6FBBBA1436C93F89B78AB0A0@CS1PR8401MB1237.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dwagner@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox