From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] brd: mark as nowait compatible
Date: Wed, 15 Feb 2023 22:08:17 -0800 [thread overview]
Message-ID: <Y+3IUcJLNK8WAkov@infradead.org> (raw)
In-Reply-To: <776a5fa2-818c-de42-2ac3-a4588df218ca@kernel.dk>
On Wed, Feb 15, 2023 at 04:43:47PM -0700, Jens Axboe wrote:
> By default, non-mq drivers do not support nowait. This causes io_uring
> to use a slower path as the driver cannot be trust not to block. brd
> can safely set the nowait flag, as worst case all it does is a NOIO
> allocation.
But a NOIO allocation can block. I think we need to do a
GFP_NOWAIT allocation in brd_insert_page if the NOWAIT flag is set.
next prev parent reply other threads:[~2023-02-16 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 23:43 [PATCH] brd: mark as nowait compatible Jens Axboe
2023-02-16 6:08 ` Christoph Hellwig [this message]
2023-02-16 13:11 ` Jens Axboe
2023-02-16 14:40 ` Christoph Hellwig
2023-02-16 14:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+3IUcJLNK8WAkov@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox