From: Ming Lei <ming.lei@redhat.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH V2] blktests: add test to cover umount one deleted disk
Date: Wed, 8 Feb 2023 15:42:24 +0800 [thread overview]
Message-ID: <Y+NSYGJBoM8Oixa5@T590> (raw)
In-Reply-To: <20230208073911.x4iwd4iq5i34xnrr@shindev>
On Wed, Feb 08, 2023 at 07:39:11AM +0000, Shinichiro Kawasaki wrote:
> On Feb 08, 2023 / 09:02, Ming Lei wrote:
> > disk can be disappear any time because of error handling, when
> > it is usually being mounted. Make sure umount can be done successfully
> > after disk deleting is done from error handling.
>
> Thanks, this patch looks good to me. The commit title needs some edit to have
> the prefix "block/032: ". I will do the edit when I apply the patch. I will
> wait a few more days in case anyone has comments.
OK, thanks!
>
> Just from my curiosity, did we have any failure that this test case catches?
https://lore.kernel.org/linux-block/20230208063552.GA15030@lst.de/T/#u
Thanks,
Ming
next prev parent reply other threads:[~2023-02-08 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 1:02 [PATCH V2] blktests: add test to cover umount one deleted disk Ming Lei
2023-02-08 7:39 ` Shinichiro Kawasaki
2023-02-08 7:42 ` Ming Lei [this message]
2023-02-08 11:43 ` Shinichiro Kawasaki
2023-02-14 4:27 ` Shinichiro Kawasaki
2023-02-14 6:37 ` Chaitanya Kulkarni
2023-02-08 10:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+NSYGJBoM8Oixa5@T590 \
--to=ming.lei@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox