From: Ming Lei <ming.lei@redhat.com>
To: Xiao Ni <xni@redhat.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/1] block: Merge bio before checking ->cached_rq
Date: Thu, 9 Feb 2023 11:41:23 +0800 [thread overview]
Message-ID: <Y+RrY2Gsf9lRQwvL@T590> (raw)
In-Reply-To: <20230209031930.27354-1-xni@redhat.com>
On Thu, Feb 09, 2023 at 11:19:30AM +0800, Xiao Ni wrote:
> It checks if plug->cached_rq is empty before merging bio. But the merge action
> doesn't have relationship with plug->cached_rq, it trys to merge bio with
> requests within plug->mq_list. Now it checks if ->cached_rq is empty before
> merging bio. If it's empty, it will miss the merge chances. So move the merge
> function before checking ->cached_rq.
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
> block/blk-mq.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Looks fine,
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2023-02-09 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 3:19 [PATCH 1/1] block: Merge bio before checking ->cached_rq Xiao Ni
2023-02-09 3:41 ` Ming Lei [this message]
2023-02-09 15:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+RrY2Gsf9lRQwvL@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox