From: Christoph Hellwig <hch@infradead.org>
To: Ye Bin <yebin10@huawei.com>
Cc: axboe@kernel.dk, rostedt@goodmis.org, mhiramat@kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 2/3] blktrace: fix possible memleak in '__blk_trace_remove'
Date: Tue, 18 Oct 2022 00:41:44 -0700 [thread overview]
Message-ID: <Y05YuJO2WDGasWdS@infradead.org> (raw)
In-Reply-To: <20221017065321.2846017-3-yebin10@huawei.com>
On Mon, Oct 17, 2022 at 02:53:20PM +0800, Ye Bin wrote:
> + if (bt->trace_state == Blktrace_running)
> + blk_trace_switch_state(bt, 0);
AFAICS blk_trace_switch_state already has that state check, so there
should be no need to duplicate it here.
I think having this call in blk_trace_cleanup itself might be a little
more obvious, too.
next prev parent reply other threads:[~2022-10-18 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 6:53 [PATCH -next 0/3] fix possible memleak in '__blk_trace_remove' Ye Bin
2022-10-17 6:53 ` [PATCH -next 1/3] blktrace: introduce 'blk_trace_swicth_state' helper Ye Bin
2022-10-18 7:40 ` Christoph Hellwig
2022-10-17 6:53 ` [PATCH -next 2/3] blktrace: fix possible memleak in '__blk_trace_remove' Ye Bin
2022-10-18 7:38 ` Yu Kuai
2022-10-18 7:41 ` Christoph Hellwig [this message]
2022-10-17 6:53 ` [PATCH -next 3/3] blktrace: remove unnessary stop block trace in 'blk_trace_shutdown' Ye Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y05YuJO2WDGasWdS@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).