From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk,
yukuai3@huawei.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH -next 4/5] blk-iocost: fix sleeping in atomic context warnning in ioc_qos_write()
Date: Sun, 30 Oct 2022 02:55:23 -0700 [thread overview]
Message-ID: <Y15KC8Zb3rHlfTPu@infradead.org> (raw)
In-Reply-To: <20221028101056.1971715-5-yukuai1@huaweicloud.com>
This seems a little convoluted to me. I'd suggest to add a new
sleeping lock that protects the updates, then you just take the
spinlock after parsing without much other changes.
(The same comment also applies to patch 5).
next prev parent reply other threads:[~2022-10-30 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:10 [PATCH -next 0/5] blk-iocost: random patches to improve configuration Yu Kuai
2022-10-28 10:10 ` [PATCH -next 1/5] blk-iocost: cleanup ioc_qos_write() and ioc_cost_model_write() Yu Kuai
2022-10-30 9:40 ` Christoph Hellwig
2022-10-28 10:10 ` [PATCH -next 2/5] blk-iocost: improve hanlder of match_u64() Yu Kuai
2022-10-30 9:40 ` Christoph Hellwig
2022-10-28 10:10 ` [PATCH -next 3/5] blk-iocost: don't allow to configure bio based device Yu Kuai
2022-10-30 9:41 ` Christoph Hellwig
2022-10-28 10:10 ` [PATCH -next 4/5] blk-iocost: fix sleeping in atomic context warnning in ioc_qos_write() Yu Kuai
2022-10-30 9:55 ` Christoph Hellwig [this message]
2022-10-31 1:33 ` Yu Kuai
2022-10-28 10:10 ` [PATCH -next 5/5] blk-iocost: fix sleeping in atomic context warnning in ioc_cost_model_write() Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y15KC8Zb3rHlfTPu@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).