From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551FCC4332F for ; Fri, 21 Oct 2022 02:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbiJUCZT (ORCPT ); Thu, 20 Oct 2022 22:25:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230084AbiJUCYz (ORCPT ); Thu, 20 Oct 2022 22:24:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8006474D3 for ; Thu, 20 Oct 2022 19:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666319077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PlZXSujXxnsONYt0iOQmULTiA4NiBkwixiMYgCgEGWg=; b=aoAf3IGMbLqJNni7Or+Mt+ppmKTosLLzBgDgv5rfwHoMReFsWJ48bgbXYg7bLvVe0jAz6E f14VwHmCtkU4YcfjK11QL/LVH+vf2Joo5Kz7eFv/EQmIQJcTdzpiIb8DkMepaYFsGmKZzE hDuzT3aJEckiHnt7LYWsj7DC0+gXr3U= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-32-V_U9RlVsN_SBAktBcmtSdQ-1; Thu, 20 Oct 2022 22:24:34 -0400 X-MC-Unique: V_U9RlVsN_SBAktBcmtSdQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9853B38012C2; Fri, 21 Oct 2022 02:24:28 +0000 (UTC) Received: from T590 (ovpn-8-24.pek2.redhat.com [10.72.8.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86F3E10DF8; Fri, 21 Oct 2022 02:24:05 +0000 (UTC) Date: Fri, 21 Oct 2022 10:23:57 +0800 From: Ming Lei To: Stefan Hajnoczi Cc: Jens Axboe , Christoph Hellwig , Bart Van Assche , djeffery@redhat.com, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [Bug] double ->queue_rq() because of timeout in ->queue_rq() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Oct 20, 2022 at 04:01:11PM -0400, Stefan Hajnoczi wrote: > On Thu, Oct 20, 2022 at 05:10:13PM +0800, Ming Lei wrote: > > Hi, > > > > David Jeffery found one double ->queue_rq() issue, so far it can > > be triggered in the following two cases: > > > > 1) scsi driver in guest kernel > > > > - the story could be long vmexit latency or long preempt latency of > > vCPU pthread, then IO req is timed out before queuing the request > > to hardware but after calling blk_mq_start_request() during ->queue_rq(), > > then timeout handler handles it by requeue, then double ->queue_rq() is > > caused, and kernel panic > > > > 2) burst of kernel messages from irq handler > > > > For 1), I think it is one reasonable case, given latency from host side > > can come anytime in theory because vCPU is emulated by one normal host > > pthread which can be preempted anywhere. For 2), I guess kernel message is > > supposed to be rate limited. > > > > Firstly, is this kind of so long(30sec) random latency when running kernel > > code something normal? Or do we need to take care of it? IMO, it looks > > reasonable in case of VM, but our VM experts may have better idea about this > > situation. Also the default 30sec timeout could be reduced via sysfs or > > drivers. > > 30 seconds is a long latency that does not occur during normal > operation, but unfortunately does happen on occasion. Thanks for the confirmation! > > I think there's an interest in understanding the root cause and solving > long latencies (if possible) in the QEMU/KVM communities. We can > investigate specific cases on kvm@vger.kernel.org and/or > qemu-devel@nongnu.org. The issue was original reported on VMware VM, but maybe David can figure out how to trigger it on QEMU/KVM. Thanks, Ming