From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA023C43217 for ; Wed, 2 Nov 2022 14:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbiKBOMT (ORCPT ); Wed, 2 Nov 2022 10:12:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbiKBOMO (ORCPT ); Wed, 2 Nov 2022 10:12:14 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9413B27CD8 for ; Wed, 2 Nov 2022 07:11:55 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id j6so12482589qvn.12 for ; Wed, 02 Nov 2022 07:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Km8d07l+If3latZbcnno8TWKH4LLZv0VkyhOoXFA9PI=; b=3K17y2wDCpq6CGFi/JqscdFCZwJGvNNaM/UrrmYofJw1wR3fGyOhi0rlaMmUvngM6N 1krgS08m59z2fr/guD+Fxxlexzk1wWL4DDBfFKhfYnmJzVrUGe1X4SPy/ewT8BQC0GfG cyN/fTXQ6bcPNPSW3tnZyUIjkUqa1IflSfWNU57n1QgVF2Pfb/1krse6RRVC5tWKohru eaMOhLitbn3Pvl2VfFWMFZMYpBalV/17Mrynnzxe6BuDm4NHgpy96rb9Ta41d8fsSuYQ 4HSWJFbdNieK8n5myVnk2FIvFji3UCt22731b4pIAwKKstvvQJ57GK52yWp62ipKzz8Y WCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Km8d07l+If3latZbcnno8TWKH4LLZv0VkyhOoXFA9PI=; b=UzUn1WcjVmqAUP3JAgPtIZlNyVsTy/YKieIZZNJCnxP44DaNz3fRKl0xg6rYP7tNy2 u76uCQt5hqEwmL/WLimbv8jMuNbz4TpLjmh5N35ajkNJqfBOEjAvwCckmVQaKTtcb2k3 zuBLX8bh9FMYfRApnTLm4xvDz3Sd22iieoSqzRx4YQcoztGHmsb136cgKHasokWOek89 vZd5wwqHN9hJ1/NRdBL689gDNy+4d1cNglczIU8edeRHxsJoGLe6CDWsNqfk1aWb2pBA 5o6teSLg13RMplwhSgjhpP3hsy9AYDr/EkLfNWWRwZhJs62rxH3OCHF9IG5u3ajFmq1n lXvQ== X-Gm-Message-State: ACrzQf2mQgVylAU8BWeRcocLza9c50VYxIgJIJ5W4qeQ2QACJcmTbyP3 QKH5zA7A3SjcOAKkIdIrXe7Yrg== X-Google-Smtp-Source: AMsMyM4K1A4U/HfQlteUYmVSAP0jWa6eNflO23gy6GLcso3nCMkqhvxGSpQm+BcuP6EyzmHHwmrnYA== X-Received: by 2002:ad4:5c47:0:b0:4bc:f84:da8f with SMTP id a7-20020ad45c47000000b004bc0f84da8fmr8748534qva.73.1667398314614; Wed, 02 Nov 2022 07:11:54 -0700 (PDT) Received: from localhost (cpe-174-109-170-245.nc.res.rr.com. [174.109.170.245]) by smtp.gmail.com with ESMTPSA id v26-20020ac8729a000000b00359961365f1sm6524563qto.68.2022.11.02.07.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 07:11:54 -0700 (PDT) Date: Wed, 2 Nov 2022 10:11:48 -0400 From: Josef Bacik To: Kemeng Shi Cc: tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] block: Correct comment for scale_cookie_change Message-ID: References: <20221018111240.22612-1-shikemeng@huawei.com> <20221018111240.22612-3-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221018111240.22612-3-shikemeng@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Oct 18, 2022 at 07:12:39PM +0800, Kemeng Shi wrote: > Default queue depth of iolatency_grp is unlimited, so we scale down > quickly(once by half) in scale_cookie_change. Remove the "subtract > 1/16th" part which is not the truth and add the actual way we > scale down. > > Signed-off-by: Kemeng Shi This is perfect, thanks Kemeng Reviewed-by: Josef Bacik Thanks, Josef