From: Johannes Weiner <hannes@cmpxchg.org>
To: Chris Mason <clm@fb.com>
Cc: hch@infradead.org, axboe@kernel.dk, linux-block@vger.kernel.org,
tj@kernel.org, riel@surriel.com
Subject: Re: [PATCH] blk-cgroup: properly pin the parent in blkcg_css_online
Date: Mon, 14 Nov 2022 14:00:10 -0500 [thread overview]
Message-ID: <Y3KQOpn102h64mEd@cmpxchg.org> (raw)
In-Reply-To: <20221114181930.2093706-1-clm@fb.com>
On Mon, Nov 14, 2022 at 10:19:30AM -0800, Chris Mason wrote:
> blkcg_css_online is supposed to pin the blkcg of the parent, but
> 397c9f46ee4d refactored things and along the way, changed it to pin the
> css instead. This results in extra pins, and we end up leaking blkcgs
> and cgroups.
>
> Fixes: 397c9f46ee4d ("blk-cgroup: move blkcg_{pin,unpin}_online out of line")
> Signed-off-by: Chris Mason <clm@fb.com>
> Spotted-by: Rik van Riel <riel@surriel.com>
> Cc: <stable@vger.kernel.org> # v5.19+
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2022-11-14 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 18:19 [PATCH] blk-cgroup: properly pin the parent in blkcg_css_online Chris Mason
2022-11-14 19:00 ` Johannes Weiner [this message]
2022-11-14 19:13 ` Jens Axboe
2022-11-15 7:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3KQOpn102h64mEd@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=riel@surriel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox