From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AECC43217 for ; Thu, 1 Dec 2022 16:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232183AbiLAQNN (ORCPT ); Thu, 1 Dec 2022 11:13:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232145AbiLAQNK (ORCPT ); Thu, 1 Dec 2022 11:13:10 -0500 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B362A17E27; Thu, 1 Dec 2022 08:13:05 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0DE55320092E; Thu, 1 Dec 2022 11:13:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 01 Dec 2022 11:13:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benboeckel.net; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1669911181; x=1669997581; bh=6v WBmCicNUpqFiwGEvCj2T5kO+IGX5hkCfNsBIQgI/Y=; b=SQKOgA4jCw2br75keg 5nM25Ni3AazbVgIu9kO/GFjV1GB+mxDVtNS3EgRwHiLst+FuAgqrCvbPy1yXQ96J MVqGkb0qOKo1WJU/Z28k/nemEolAPiD+Td3YlnzFINRxN6qB9X2KpF/L06Sm3B54 nfA8VPFb2iLVmKIDpvikU8yhdiwdAxhwW7eSJGCas6AG6DyN2iVCCKg2NVn78iGO IqmbzbWTmbZP5Zv3MZ9h+ywzSS4Lde3rYMAs7MXemeAGh5gWvNsk0ufMEekaIDUU xQ3ZukJoPzuPHzNRLRfV4k73IDp5i26gRy+8mosGx5qWK1JWb7oWP2sHWdAYVqkk gSMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669911181; x=1669997581; bh=6vWBmCicNUpqFiwGEvCj2T5kO+IG X5hkCfNsBIQgI/Y=; b=tutfjdV228slV4DB1ouLQaOkA3QksQHTgae4JoI5dvzE CyVOxLAmykS23EhjNR1AVUJH71dR2/5g+QhwCimj9h4a11u6zXeiEtoynHnly2zJ PZirfTzThPfC+c7Rn6QYdzmuD9ScQH5ejHY/sFRNazIO/WlW0X3s3J1yyDhRHQsO qkA/ZhRdQBqlBhm4H1HkEzk3XEHuwNxBerIBA0YC2AG90r579LIHUZ6TNzrMqY4g DSimavHWsWQZyUMNuMHB+UJPpHW+hxPzE8lElUWT9awbfIMoAtRcQBaH7CwdSH/I ulX2IlSjKvSKyKCLluHA+us7l74aBzgH29D2VTIp5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdehgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjfgesthdtredttderjeenucfhrhhomhepuegvnhcu uehovggtkhgvlhcuoehmvgessggvnhgsohgvtghkvghlrdhnvghtqeenucggtffrrghtth gvrhhnpeffleegffevleekffekheeigfdtleeuvddtgffhtddvfefgjeehffduueevkedv vdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmvg essggvnhgsohgvtghkvghlrdhnvght X-ME-Proxy: Feedback-ID: iffc1478b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Dec 2022 11:13:00 -0500 (EST) Date: Thu, 1 Dec 2022 11:12:59 -0500 From: Ben Boeckel To: Greg Joyce Cc: Hannes Reinecke , linux-block@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, jonathan.derrick@linux.dev, brking@linux.vnet.ibm.com, msuchanek@suse.de, mpe@ellerman.id.au, nayna@linux.ibm.com, axboe@kernel.dk, akpm@linux-foundation.org, keyrings@vger.kernel.org Subject: Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys Message-ID: References: <20221129232506.3735672-1-gjoyce@linux.vnet.ibm.com> <20221129232506.3735672-4-gjoyce@linux.vnet.ibm.com> <2133c00e5e7c53c458dbb709204c955bac8bee88.camel@linux.vnet.ibm.com> <044c90dc7feb3959b5740154addc230ba9a57216.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <044c90dc7feb3959b5740154addc230ba9a57216.camel@linux.vnet.ibm.com> User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Dec 01, 2022 at 09:29:36 -0600, Greg Joyce wrote: > On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > > Perhaps naming it `OPAL_MAX_KEY_LEN` would help clarify this? > > I'm not averse to changing it because it would be clearer. My concern > is that it's been OPAL_KEY_MAX for 5+ years (the original SED Opal > commit). Unless there is strong consensus to change it, I'm going to > leave it as the original name. I don't care about the name (very much in the peanut gallery), just it not being a magic number :) . --Ben