From: Christoph Hellwig <hch@infradead.org>
To: Suwan Kim <suwan.kim027@gmail.com>
Cc: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, hch@infradead.org, axboe@kernel.dk,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 2/2] virtio-blk: support completion batching for the IRQ path
Date: Wed, 21 Dec 2022 02:48:30 -0800 [thread overview]
Message-ID: <Y6LkfrTVV/M2eye/@infradead.org> (raw)
In-Reply-To: <20221220153613.21675-3-suwan.kim027@gmail.com>
> + if (likely(!blk_should_fake_timeout(req->q)) &&
> + !blk_mq_complete_request_remote(req) &&
> + !blk_mq_add_to_batch(req, iob, vbr->status,
> + virtblk_complete_batch))
One tab indents for line continuations are really confusing. Please
make this:
if (likely(!blk_should_fake_timeout(req->q)) &&
!blk_mq_complete_request_remote(req) &&
!blk_mq_add_to_batch(req, iob, vbr->status,
virtblk_complete_batch))
> + found = virtblk_handle_req(vq, iob);
>
> if (found)
You can drop the found variable here now:
if (virtblk_handle_req(vq, iob))
blk_mq_start_stopped_hw_queues(vblk->disk->queue, true);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-12-21 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 15:36 [PATCH v2 0/2] virtio-blk: set req->state to MQ_RQ_COMPLETE and support completion batching for the IRQ path Suwan Kim
2022-12-20 15:36 ` [PATCH v2 1/2] virtio-blk: set req->state to MQ_RQ_COMPLETE after polling I/O is finished Suwan Kim
2022-12-21 10:45 ` Christoph Hellwig
2022-12-20 15:36 ` [PATCH v2 2/2] virtio-blk: support completion batching for the IRQ path Suwan Kim
2022-12-21 10:48 ` Christoph Hellwig [this message]
2022-12-21 13:45 ` Suwan Kim
2022-12-21 14:15 ` Suwan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6LkfrTVV/M2eye/@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=suwan.kim027@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).