From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC89AC63797 for ; Tue, 17 Jan 2023 07:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235457AbjAQH6i (ORCPT ); Tue, 17 Jan 2023 02:58:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235824AbjAQH6X (ORCPT ); Tue, 17 Jan 2023 02:58:23 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D278025E0F; Mon, 16 Jan 2023 23:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b0nS55MfXPyMov4axRHGXQeYFTCNO98nDj10cXmRS1Y=; b=QlWgpAfqbJ/Wm1Rsi5gnTq5sVM FeuoUlhWDiuQ9jMsZIlCZ2S1ne2SwCsMNg53tZY5unUhoPM6b5nHYWZE5kdWALzD2OqSe7n14Z6l2 ClXxY41oAuUcqKztDjR+0RwBKrDGlTyGdOcTWjKMqcH7gmIt/iPP/qAo/btu0jHCkmlXRY7yippOe a7DhXxwjr90om/RDe2lXvEJ58P/lnG/audGrflA7+k24JvT7TWuE1mO44KKWRJ9xViQWbhUJZ6OYH umSmytHhF5quOMVl49y9nj8hTjNsv1e2GXx2sIPX0b10k5sGSATLIin0efVEcTbhPHZB10UdxFd8r 2ZX6KSAA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHgrI-00DGCj-7W; Tue, 17 Jan 2023 07:58:16 +0000 Date: Mon, 16 Jan 2023 23:58:16 -0800 From: Christoph Hellwig To: David Howells Cc: Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions Message-ID: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391052497.2311931.9463379582932734164.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167391052497.2311931.9463379582932734164.stgit@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jan 16, 2023 at 11:08:44PM +0000, David Howells wrote: > Use the direction in the iterator functions rather than READ/WRITE. I don't think we need the direction at all as nothing uses it any more. Maybe don't crate churn there until that's been sorted.