From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA69C63797 for ; Tue, 17 Jan 2023 11:12:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235898AbjAQLM0 (ORCPT ); Tue, 17 Jan 2023 06:12:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236705AbjAQLMC (ORCPT ); Tue, 17 Jan 2023 06:12:02 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E980916AD5; Tue, 17 Jan 2023 03:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BVFQ/Mb2qATOaXsdVnOfEZtNtm7Q+bb3RevusSz1Plw=; b=xiL/0sO8Gjb0UodROfe4U2jQC3 gkDpTuQ5C6ygv9Y3S/cpm8GMGMKFJ6psf27ThZSiLpwPTA5kSRmpBffTiSEh/0urhFj13TxQZNPvA ezYKemecGXkPQh/WVWr2JzMoOcmfPKizPZ7NEqLJRgN8aX3NJYtGtnaeW1TnATT5FVEiig20hymLH 1mTrplTPfWZRjyO4/wyL4AutoBupPFqdRQ8Zl+J5j1FScWjoq0jTlTgRO1TDRLCSe3KacjHizikCa /mKIFBK/Kh1+efnztyZHnGHc4oyF72CrENx2kEM8lsvILTtD05zbuq8y6cD4pajd2x69KGoXlgDni YQzfFudg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHjse-00DxVD-LU; Tue, 17 Jan 2023 11:11:52 +0000 Date: Tue, 17 Jan 2023 03:11:52 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Al Viro , Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter() Message-ID: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391048988.2311931.1567396746365286847.stgit@warthog.procyon.org.uk> <2337531.1673953876@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2337531.1673953876@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jan 17, 2023 at 11:11:16AM +0000, David Howells wrote: > So something like: > > init_kiocb(kiocb, file, WRITE); > init_kiocb(kiocb, file, READ); Yes.