Re: [RFC PATCH 1/7] block: Support creating a struct file from a block device

Demi Marie Obenour
2023-01-30T19:22:46Z

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Mon, Jan 30, 2023 at 12:08:23AM -0800, Christoph Hellwig wrote:
> On Wed, Jan 25, 2023 at 10:33:53PM -0500, Demi Marie Obenour wrote:
> > The newly added blkdev_get_file() function allows kernel code to create
> > a struct file for any block device. The main use-case is for the
> > struct file to be exposed to userspace as a file descriptor. A future
> > patch will modify the DM_DEV_CREATE_CREATE ioctl to allow userspace to
> > get a file descriptor to the newly created block device, avoiding nasty
> > race conditions.
>
> NAK. Do not add wierd side-way interfaces to the block layer.

What do you recommend instead? This solves a real problem for
device-mapper users and I am not aware of a better solution.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]