From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 03/11] block: introduce BIO_ZONE_WRITE_LOCKED bio flag
Date: Wed, 19 May 2021 10:41:37 +0100 [thread overview]
Message-ID: <YKTdUYIizUPCtiTa@infradead.org> (raw)
In-Reply-To: <20210519025529.707897-4-damien.lemoal@wdc.com>
On Wed, May 19, 2021 at 11:55:21AM +0900, Damien Le Moal wrote:
> Introduce the BIO flag BIO_ZONE_WRITE_LOCKED to indicate that a BIO owns
> the write lock of the zone it is targeting. This is the counterpart of
> the struct request flag RQF_ZONE_WRITE_LOCKED. This new BIO flag is
> reserved for now for zone write locking control for device mapper
> targets exposing a zoned block device.
So normally we try to use a REQ_* flag instead of duplicate BIO_ and
RQF ones. But I think this is a special case as the flag never gets
propagated. Can you document that in the commit log?
With that:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-05-19 9:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 2:55 [PATCH 00/11] dm: Improve zoned block device support Damien Le Moal
2021-05-19 2:55 ` [PATCH 01/11] block: improve handling of all zones reset operation Damien Le Moal
2021-05-19 9:35 ` Christoph Hellwig
2021-05-19 9:48 ` Damien Le Moal
2021-05-19 2:55 ` [PATCH 02/11] block: introduce bio zone helpers Damien Le Moal
2021-05-19 7:17 ` Johannes Thumshirn
2021-05-19 7:42 ` Chaitanya Kulkarni
2021-05-19 8:27 ` Damien Le Moal
2021-05-19 9:38 ` Christoph Hellwig
2021-05-19 2:55 ` [PATCH 03/11] block: introduce BIO_ZONE_WRITE_LOCKED bio flag Damien Le Moal
2021-05-19 9:41 ` Christoph Hellwig [this message]
2021-05-19 9:50 ` Damien Le Moal
2021-05-19 2:55 ` [PATCH 04/11] dm: Fix dm_accept_partial_bio() Damien Le Moal
2021-05-19 7:37 ` Johannes Thumshirn
2021-05-19 2:55 ` [PATCH 05/11] dm: cleanup device_area_is_invalid() Damien Le Moal
2021-05-19 7:36 ` Johannes Thumshirn
2021-05-19 2:55 ` [PATCH 06/11] dm: move zone related code to dm-zone.c Damien Le Moal
2021-05-19 7:38 ` Johannes Thumshirn
2021-05-19 2:55 ` [PATCH 07/11] dm: Introduce dm_report_zones() Damien Le Moal
2021-05-19 7:49 ` Johannes Thumshirn
2021-05-19 2:55 ` [PATCH 08/11] dm: Forbid requeue of writes to zones Damien Le Moal
2021-05-19 2:55 ` [PATCH 09/11] dm: rearrange core declarations Damien Le Moal
2021-05-19 2:55 ` [PATCH 10/11] dm: introduce zone append emulation Damien Le Moal
2021-05-19 2:55 ` [PATCH 11/11] dm crypt: Fix zoned block device support Damien Le Moal
2021-05-19 15:45 ` [dm-devel] " Milan Broz
2021-05-20 0:00 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKTdUYIizUPCtiTa@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox