From: Christoph Hellwig <hch@infradead.org>
To: colyli@suse.de
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
Diego Ercolani <diego.ercolani@gmail.com>,
Jan Szubiak <jan.szubiak@linuxpolska.pl>,
Marco Rebhan <me@dblsaiko.net>,
Matthias Ferdinand <bcache@mfedv.net>,
Thorsten Knabe <linux@thorsten-knabe.de>,
Victor Westerhuis <victor@westerhu.is>,
Vojtech Pavlik <vojtech@suse.cz>,
stable@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: [PATCH v3] bcache: avoid oversized read request in cache missing code path
Date: Thu, 20 May 2021 09:05:09 +0100 [thread overview]
Message-ID: <YKYYNVD+NsXaOFNe@infradead.org> (raw)
In-Reply-To: <20210518110009.11413-1-colyli@suse.de>
This fix is pretty gross. Adding pages to bios can fail for all kinds
of reasons, so the fix is to use bio_add_page and check its return
value, and if it needs another bio keep looping and chaining more bios.
And maybe capping the readahead to some sane upper bound still makes
sense, but it should never look at BIO_MAX_VECS for that.
next prev parent reply other threads:[~2021-05-20 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 11:00 [PATCH v3] bcache: avoid oversized read request in cache missing code path colyli
2021-05-20 8:05 ` Christoph Hellwig [this message]
2021-05-21 3:30 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKYYNVD+NsXaOFNe@infradead.org \
--to=hch@infradead.org \
--cc=bcache@mfedv.net \
--cc=colyli@suse.de \
--cc=diego.ercolani@gmail.com \
--cc=jan.szubiak@linuxpolska.pl \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@thorsten-knabe.de \
--cc=me@dblsaiko.net \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=victor@westerhu.is \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).