From: Minchan Kim <minchan@kernel.org>
To: Yue Hu <zbestahu@gmail.com>, akpm@linux-foundation.org
Cc: ngupta@vflare.org, senozhatsky@chromium.org, axboe@kernel.dk,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
huyue2@yulong.com, zbestahu@163.com,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH][RESEND] zram: move backing_dev under macro CONFIG_ZRAM_WRITEBACK
Date: Fri, 21 May 2021 10:44:32 -0700 [thread overview]
Message-ID: <YKfxgGe6evFf7dr+@google.com> (raw)
In-Reply-To: <20210521060544.2385-1-zbestahu@gmail.com>
On Fri, May 21, 2021 at 02:05:44PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> backing_dev is never used when not enable CONFIG_ZRAM_WRITEBACK and
> it's introduced from writeback feature. So it's needless also affect
> readability in that case.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Acked-by: Minchan Kim <minchan@kernel.org>
Andrew, could you pick?
> ---
> drivers/block/zram/zram_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
> index 419a7e8..6e73dc3 100644
> --- a/drivers/block/zram/zram_drv.h
> +++ b/drivers/block/zram/zram_drv.h
> @@ -113,8 +113,8 @@ struct zram {
> * zram is claimed so open request will be failed
> */
> bool claim; /* Protected by bdev->bd_mutex */
> - struct file *backing_dev;
> #ifdef CONFIG_ZRAM_WRITEBACK
> + struct file *backing_dev;
> spinlock_t wb_limit_lock;
> bool wb_limit_enable;
> u64 bd_wb_limit;
> --
> 1.9.1
>
prev parent reply other threads:[~2021-05-21 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 6:05 [PATCH][RESEND] zram: move backing_dev under macro CONFIG_ZRAM_WRITEBACK Yue Hu
2021-05-21 17:44 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKfxgGe6evFf7dr+@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=huyue2@yulong.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=zbestahu@163.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).