From: Christoph Hellwig <hch@infradead.org>
To: Edward Hsieh <edwardh@synology.com>
Cc: Christoph Hellwig <hch@infradead.org>,
axboe@kernel.dk, neilb@suse.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, s3t@synology.com,
bingjingc@synology.com, cccheng@synology.com,
Wade Liang <wadel@synology.com>
Subject: Re: [PATCH v3] block: fix trace completion for chained bio
Date: Thu, 24 Jun 2021 08:02:05 +0100 [thread overview]
Message-ID: <YNQt7XtxrFhLhS7E@infradead.org> (raw)
In-Reply-To: <1204c32a-e3b3-95dd-b2b5-b9f6eef4f022@synology.com>
On Thu, Jun 24, 2021 at 02:50:30PM +0800, Edward Hsieh wrote:
> We are suggested by Neil Brown in the last version that from the
> comment, the bio_chain_endio handling is used *only* to avoid
> deep recursion so it should be at the end of the function.
> Therefore, the position of blk_throtl_bio_endio() and bio_uninit()
> are a bit odd.
This is BS. Placement of an else after a returning statement does
not change code generation.
> If it's not necessary then V2 patch should work to fix the
> missing completion traces. Should we resend PATCH V2?
Please send an updated version.
prev parent reply other threads:[~2021-06-24 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 3:08 [PATCH v3] block: fix trace completion for chained bio edwardh
2021-06-16 4:53 ` Christoph Hellwig
2021-06-24 6:50 ` Edward Hsieh
2021-06-24 7:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNQt7XtxrFhLhS7E@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bingjingc@synology.com \
--cc=cccheng@synology.com \
--cc=edwardh@synology.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=s3t@synology.com \
--cc=wadel@synology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).