From: Christoph Hellwig <hch@infradead.org>
To: brookxu <brookxu.cn@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] block: fix the problem of io_ticks becoming smaller
Date: Tue, 6 Jul 2021 06:25:07 +0100 [thread overview]
Message-ID: <YOPpM6et9rFNrBOn@infradead.org> (raw)
In-Reply-To: <1625521646-1069-1-git-send-email-brookxu.cn@gmail.com>
On Tue, Jul 06, 2021 at 05:47:26AM +0800, brookxu wrote:
> From: Chunguang Xu <brookxu@tencent.com>
>
> On the IO submission path, blk_account_io_start() may interrupt
> the system interruption. When the interruption returns, the value
> of part->stamp may have been updated by other cores, so the time
> value collected before the interruption may be less than part->
> stamp. So when this happens, we should do nothing to make io_ticks
> more accurate? For kernels less than 5.0, this may cause io_ticks
> to become smaller, which in turn may cause abnormal ioutil values.
>
> v3: update the commit log
> v2: sorry, fix compile error due to the missed ')'
>
> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
The change looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although I still have trouble understanding the commit log, especially
the last sentence.
next prev parent reply other threads:[~2021-07-06 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 21:47 [PATCH v3] block: fix the problem of io_ticks becoming smaller brookxu
2021-07-06 5:25 ` Christoph Hellwig [this message]
2021-07-06 12:00 ` brookxu
2021-07-07 10:46 ` Ming Lei
2021-07-07 12:44 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOPpM6et9rFNrBOn@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox