From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D70FC636C8 for ; Tue, 20 Jul 2021 11:17:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BC2F60FDB for ; Tue, 20 Jul 2021 11:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236458AbhGTKhA (ORCPT ); Tue, 20 Jul 2021 06:37:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231442AbhGTKg7 (ORCPT ); Tue, 20 Jul 2021 06:36:59 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD5CC061574; Tue, 20 Jul 2021 04:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4FkZvqXeAIk4BuCEW9n8PvCXADxw3t7wT89TribEmJ4=; b=dGlxFd7VdA60iqtsgKTmLNv6gL zuMCMdEGLQhXpslEtymGFCdaZSQ+RefhzQqO+vUjOMjCU+EhnKhnxiQdm8sCEMIK9YfIe80VY89eQ mk4wGqYpWRryKk9cIT46Jld57JGhixwB1Q4yeSzwgzt7eQdChsS80zxItJTM4LCtJBHtMQIJxbC6g GwNR7KGWmNytX6w85Gokb7aq1KbwHrcDdxkX1JZljXMuLomALqJZtOkyPy1+o4hVCnpgdL+MwbTyb DiOZzif46Sd1RS2ObzKCdaBp9XEIN4eS+DqLdrs81vTXrZJ4y5MxyObgnL1XuVmqfVfP8F6RLPs7H egrYC1zw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5nk5-0082bU-1k; Tue, 20 Jul 2021 11:17:03 +0000 Date: Tue, 20 Jul 2021 12:16:53 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH v15 01/17] block: Add bio_add_folio() Message-ID: References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jul 20, 2021 at 07:42:00AM +0100, Christoph Hellwig wrote: > On Mon, Jul 19, 2021 at 07:39:45PM +0100, Matthew Wilcox (Oracle) wrote: > > +/** > > + * bio_add_folio - Attempt to add part of a folio to a bio. > > + * @bio: Bio to add to. > > + * @folio: Folio to add. > > + * @len: How many bytes from the folio to add. > > + * @off: First byte in this folio to add. > > + * > > + * Always uses the head page of the folio in the bio. If a submitter only > > + * uses bio_add_folio(), it can count on never seeing tail pages in the > > + * completion routine. BIOs do not support folios that are 4GiB or larger. > > + * > > + * Return: The number of bytes from this folio added to the bio. > > + */ > > +size_t bio_add_folio(struct bio *bio, struct folio *folio, size_t len, > > + size_t off) > > +{ > > + if (len > UINT_MAX || off > UINT_MAX) > > + return 0; > > + return bio_add_page(bio, &folio->page, len, off); > > +} > > I'd use the opportunity to switch to a true/false return instead of > the length. This has been on my todo list for bio_add_page for a while, > so it might make sense to start out the new API the right way. ok.