Re: [PATCHSET v3 0/5] Enable bio recycling for polled IO

Christoph Hellwig
2021-08-11T15:09:02Z

On Wed, Aug 11, 2021 at 09:05:47AM -0600, Jens Axboe wrote:
> On 8/11/21 5:13 AM, Christoph Hellwig wrote:
> > On Wed, Aug 11, 2021 at 09:26:33AM +0100, Christoph Hellwig wrote:
> >> I really don't like all the layering violations in here. What is the
> >> problem with a simple (optional) percpu cache in the bio_set? Something
> >> like the completely untested patch below:
> >
> > A slightly updated version that actually compiles and survives minimal
> > testing is here:
> >
> > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bio-cache
>
> I like this approach, I've done something very similar in the past. But
> the key here is the opt-in, to avoid needing IRQ/locking for the cache
> which defeats the purpose. That's why it was done just for polling,
> obviously.
>
> I'll test a bit and re-spin the series.

The series above now has the opt-in as I realized the same after a
little testing.