Re: [PATCH v2 06/11] blk-mq: Pass driver tags to blk_mq_clear_rq_mapping()

Ming Lei
2021-08-19T00:39:45Z

On Wed, Aug 18, 2021 at 01:00:13PM +0100, John Garry wrote:
> > > @@ -2346,8 +2345,11 @@ static void blk_mq_clear_rq_mapping(struct blk_mq_tag_set *set,
> > > void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
> > > unsigned int hctx_idx)
> > > {
> > > + struct blk_mq_tags *drv_tags;
> > > struct page *page;
> > > + drv_tags = set->tags[hctx_idx];
> >
>
> Hi Ming,
>
> > Indent.
>
> That's intentional, as we have from later patch:
>
> void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags,
> unsigned int hctx_idx)
> {
> struct blk_mq_tags *drv_tags;
> struct page *page;
>
> + if (blk_mq_is_sbitmap_shared(set->flags))
> + drv_tags = set->shared_sbitmap_tags;
> + else
> drv_tags = set->tags[hctx_idx];
>
> ...
>
> blk_mq_clear_rq_mapping(drv_tags, tags);
>
> }
>
> And it's just nice to not re-indent later.

But this way is weird, and I don't think checkpatch.pl is happy with
it.

--
Ming