Re: [PATCH 13/13] xfs: convert xfs_sysfs attrs to use ->seq_show

Greg Kroah-Hartman
2021-09-15T07:07:35Z

On Wed, Sep 15, 2021 at 09:04:45AM +0200, Christoph Hellwig wrote:
> On Tue, Sep 14, 2021 at 05:41:37PM +0200, Greg Kroah-Hartman wrote:
> > They huge majority of sysfs attributes are "trivial". So for maybe at
> > least 95% of the users, if not more, using sysfs_emit() is just fine as
> > all you "should" be doing is emitting a single value.
>
> It is just fine if no one does the obvious mistakes that an interface
> with a char * pointer leads to. And 5% of all attributes is still a huge
> attack surface.

It is probably less, I just pulled that number out of the air. With the
other work we are doing to make sure we have documentation for all sysfs
attributes in the kernel, we will soon know the real number.

thanks,

greg k-h