From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6473EC433EF for ; Wed, 29 Sep 2021 08:04:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 400CA613C8 for ; Wed, 29 Sep 2021 08:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244241AbhI2IGX (ORCPT ); Wed, 29 Sep 2021 04:06:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36269 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244361AbhI2IGW (ORCPT ); Wed, 29 Sep 2021 04:06:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632902681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E3crSTrUNdR0NaQQrRsu6FRgIiQrkJ+OMm9iOREuUAY=; b=OoHYfVozVroM3m16HKn2UqLw0l39istPoZk8mnOBSfAH+Aey3xaPNMv7przyQEF3s7cII8 R4eYksM6EbJjRT0FiIbIVO6aVVf7ScVF4/7WFZA/Jo+zPqu4oabyWAmN8vPEZTjubqzGWn JfImQtBywtQpps/YO+QH6e/fTCeeKKs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-OMvHV8brMSiPaBwniWU4tw-1; Wed, 29 Sep 2021 04:04:39 -0400 X-MC-Unique: OMvHV8brMSiPaBwniWU4tw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5080D5074D; Wed, 29 Sep 2021 08:04:37 +0000 (UTC) Received: from T590 (ovpn-8-18.pek2.redhat.com [10.72.8.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4DE71007606; Wed, 29 Sep 2021 08:04:30 +0000 (UTC) Date: Wed, 29 Sep 2021 16:04:25 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , "Martin K. Petersen" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linux-scsi@vger.kernel.org Subject: Re: remove ->rq_disk Message-ID: References: <20210928052211.112801-1-hch@lst.de> <20210929070733.GA31869@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929070733.GA31869@lst.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Sep 29, 2021 at 09:07:33AM +0200, Christoph Hellwig wrote: > On Tue, Sep 28, 2021 at 10:32:51PM +0800, Ming Lei wrote: > > Hello Christoph, > > > > On Tue, Sep 28, 2021 at 07:22:06AM +0200, Christoph Hellwig wrote: > > > Hi Jens, > > > > > > this series removes the rq_disk field in struct request, which isn't > > > needed now that we can get the disk from the request_queue. > > > > Can we hold on this series until q->disk becomes really reliable[1][2]? > > It's not like q->disk isn't reliable. It is that we don't kill all bios q->disk will be cleaned in gendisk's release handler, which may happen before or after blk_cleanup_queue(). > when tearing down the gendisk, which is an old problem that got worse. It is fine to not kill all bios when tearing down gendisk if BDI isn't retrieved from q->disk->bdi since gendisk has same lifetime with bdev. So what is the old problem? > That being said I'm resending this again. No, either your patch or mine can't fix the issue, and I will comment on your resending. Thanks, Ming