From: Christoph Hellwig <hch@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-block@vger.kernel.org, linux-mmc@vger.kernel.org,
tglx@linutronix.de, Ulf Hansson <ulf.hansson@linaro.org>,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2 1/2] blk-mq: Add blk_mq_complete_request_direct()
Date: Mon, 18 Oct 2021 08:20:50 -0700 [thread overview]
Message-ID: <YW2Q0ikJR13NWgGD@infradead.org> (raw)
In-Reply-To: <20211018135559.244400-2-bigeasy@linutronix.de>
On Mon, Oct 18, 2021 at 03:55:58PM +0200, Sebastian Andrzej Siewior wrote:
> +static inline void blk_mq_complete_request_direct(struct request *rq,
> + void (*complete)(struct request *rq))
Pleae avoid the overly long line.
ote that by doing the normal two tab indent for the continuation that
would be super trivial and way more readable.
next prev parent reply other threads:[~2021-10-18 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 13:55 [PATCH v2 0/2] blk-mq: Allow to complete requests directly Sebastian Andrzej Siewior
2021-10-18 13:55 ` [PATCH v2 1/2] blk-mq: Add blk_mq_complete_request_direct() Sebastian Andrzej Siewior
2021-10-18 15:20 ` Christoph Hellwig [this message]
2021-10-25 6:45 ` Sebastian Andrzej Siewior
2021-10-18 13:55 ` [PATCH v2 2/2] mmc: core: Use blk_mq_complete_request_direct() Sebastian Andrzej Siewior
2021-10-19 11:32 ` Ulf Hansson
2021-10-20 6:39 ` Adrian Hunter
2021-10-25 6:44 ` Sebastian Andrzej Siewior
2021-10-21 19:45 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW2Q0ikJR13NWgGD@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).