Re: [PATCH 4/4] block: move update request helpers into blk-mq.c

Christoph Hellwig
2021-10-13T17:33:56Z

On Wed, Oct 13, 2021 at 10:49:37AM -0600, Jens Axboe wrote:
> For some reason we still have them in blk-core, with the rest of the
> request completion being in blk-mq. That causes and out-of-line call
> for each completion.
>
> Move them into blk-mq.c instead.

The status/errno helpers really are core code. And if we change
the block_rq_complete tracepoint to just take the status and do the
conversion inside the trace event to avoid the fast path out of line
call.