Re: [PATCH 3/4] block: don't bother iter advancing a fully done bio

Jens Axboe
2021-10-13T17:46:27Z

On 10/13/21 11:26 AM, Christoph Hellwig wrote:
> On Wed, Oct 13, 2021 at 10:49:36AM -0600, Jens Axboe wrote:
>> +extern void __bio_advance(struct bio *, unsigned);
>
> No need for the extern, but it would be nice to spell out the argument
> names.

Done

>> +static inline void bio_advance(struct bio *bio, unsigned int nbytes)
>> +{
>
> The kerneldoc comment for bio_advance needs to move here now.

Ah yes, done.

--
Jens Axboe