From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: replace always false argument with 'false'
Date: Tue, 2 Nov 2021 08:26:23 +0800 [thread overview]
Message-ID: <YYCFr6mjciIwqT2W@T590> (raw)
In-Reply-To: <7d6a5cde-1a98-55ef-4094-d9286d51fecd@kernel.dk>
On Mon, Nov 01, 2021 at 01:42:16PM -0600, Jens Axboe wrote:
> A previous commit fixed up the condition for doing direct issue, but that
> left the 'from_schedule' argument dead inside the branch. Replace it with
> 'false'.
>
> Fixes: ff1552232b36 ("blk-mq: don't issue request directly in case that current is to be blocked")
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> ---
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 4787d5b74aa3..8aed6cea3a34 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2227,7 +2227,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
> plug->rq_count = 0;
>
> if (!plug->multiple_queues && !plug->has_elevator && !from_schedule) {
> - blk_mq_plug_issue_direct(plug, from_schedule);
> + blk_mq_plug_issue_direct(plug, false);
> if (rq_list_empty(plug->mq_list))
> return;
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
prev parent reply other threads:[~2021-11-02 0:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 19:42 [PATCH] block: replace always false argument with 'false' Jens Axboe
2021-11-02 0:26 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYCFr6mjciIwqT2W@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox