From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/4] block: have plug stored requests hold references to the queue
Date: Thu, 4 Nov 2021 02:01:34 -0700 [thread overview]
Message-ID: <YYOhbiRY0xFAyVEE@infradead.org> (raw)
In-Reply-To: <20211103183222.180268-2-axboe@kernel.dk>
> @@ -1643,7 +1643,7 @@ void blk_flush_plug(struct blk_plug *plug, bool from_schedule)
> flush_plug_callbacks(plug, from_schedule);
> if (!rq_list_empty(plug->mq_list))
> blk_mq_flush_plug_list(plug, from_schedule);
> - if (unlikely(!from_schedule && plug->cached_rq))
> + if (unlikely(!rq_list_empty(plug->cached_rq)))
How is this related to the rest of the patch?
next prev parent reply other threads:[~2021-11-04 9:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 18:32 [PATCHSET 0/4] Alloc batch fixes Jens Axboe
2021-11-03 18:32 ` [PATCH 1/4] block: have plug stored requests hold references to the queue Jens Axboe
2021-11-04 9:01 ` Christoph Hellwig [this message]
2021-11-04 11:33 ` Jens Axboe
2021-11-03 18:32 ` [PATCH 2/4] block: make blk_try_enter_queue() available for blk-mq Jens Axboe
2021-11-03 18:32 ` [PATCH 3/4] block: move queue enter logic into blk_mq_submit_bio() Jens Axboe
2021-11-04 9:10 ` Christoph Hellwig
2021-11-04 11:41 ` Jens Axboe
2021-11-04 12:14 ` Jens Axboe
2021-11-04 17:32 ` Christoph Hellwig
2021-11-04 17:35 ` Jens Axboe
2021-11-04 17:30 ` Christoph Hellwig
2021-11-04 17:36 ` Jens Axboe
2021-11-03 18:32 ` [PATCH 4/4] block: move plug rq alloc into helper and ensure queue match Jens Axboe
2021-11-04 9:17 ` Christoph Hellwig
2021-11-04 11:35 ` Jens Axboe
2021-11-04 17:33 ` Christoph Hellwig
2021-11-04 17:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYOhbiRY0xFAyVEE@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).