public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Jan Kara <jack@suse.cz>, Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH 0/2] block: Fix stale page cache of discard or zero out ioctl
Date: Tue, 9 Nov 2021 19:07:26 +0800	[thread overview]
Message-ID: <YYpWbnPK+K1kQ3Z4@T590> (raw)
In-Reply-To: <20211109104723.835533-1-shinichiro.kawasaki@wdc.com>

On Tue, Nov 09, 2021 at 07:47:21PM +0900, Shin'ichiro Kawasaki wrote:
> When BLKDISCARD or BLKZEROOUT ioctl race with data read, stale page cache is
> left. This patch series have two fox patches for the stale page cache. Same
> fix approach was used as blkdev_fallocate() [1].
> 
> [1] https://marc.info/?l=linux-block&m=163236463716836
> 
> Shin'ichiro Kawasaki (2):
>   block: Hold invalidate_lock in BLKDISCARD ioctl
>   block: Hold invalidate_lock in BLKZEROOUT ioctl
> 
>  block/ioctl.c | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)

Yeah, the discard ioctl needs such fixes too, seems it isn't triggered
in the test disk of my test VM when running block/009.

BTW, BLKRESETZONE may need the fix too.


Thanks,
Ming


  parent reply	other threads:[~2021-11-09 11:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 10:47 [PATCH 0/2] block: Fix stale page cache of discard or zero out ioctl Shin'ichiro Kawasaki
2021-11-09 10:47 ` [PATCH 1/2] block: Hold invalidate_lock in BLKDISCARD ioctl Shin'ichiro Kawasaki
2021-11-09 11:59   ` Jan Kara
2021-11-09 10:47 ` [PATCH 2/2] block: Hold invalidate_lock in BLKZEROOUT ioctl Shin'ichiro Kawasaki
2021-11-09 11:59   ` Jan Kara
2021-11-09 11:07 ` Ming Lei [this message]
2021-11-09 11:59   ` [PATCH 0/2] block: Fix stale page cache of discard or zero out ioctl Jan Kara
2021-11-09 12:49     ` Shinichiro Kawasaki
2021-11-09 14:33 ` Jens Axboe
2021-11-10  1:13   ` Shinichiro Kawasaki
2021-11-09 17:11 ` Jens Axboe
2021-11-10  6:37 ` Chaitanya Kulkarni
2021-11-10  6:47   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYpWbnPK+K1kQ3Z4@T590 \
    --to=ming.lei@redhat.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox