From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 3/4] nvme: separate command prep and issue
Date: Tue, 16 Nov 2021 22:17:27 -0800 [thread overview]
Message-ID: <YZSedy1bGe30XEHW@infradead.org> (raw)
In-Reply-To: <20211117033807.185715-4-axboe@kernel.dk>
On Tue, Nov 16, 2021 at 08:38:06PM -0700, Jens Axboe wrote:
> + ret = nvme_prep_rq(dev, ns, req, &iod->cmd);
> + if (ret == BLK_STS_OK) {
> + nvme_submit_cmd(nvmeq, &iod->cmd, bd->last);
> + return BLK_STS_OK;
> + }
> + return ret;
I'd prefer the traditional handle errors outside the straight path
order here:
ret = nvme_prep_rq(dev, ns, req, &iod->cmd);
if (ret)
return ret;
nvme_submit_cmd(nvmeq, &iod->cmd, bd->last);
return BLK_STS_OK;
next prev parent reply other threads:[~2021-11-17 6:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 3:38 [PATCHSET 0/4] Add support for list issue Jens Axboe
2021-11-17 3:38 ` [PATCH 1/4] block: add mq_ops->queue_rqs hook Jens Axboe
2021-11-17 6:25 ` Christoph Hellwig
2021-11-17 15:41 ` Jens Axboe
2021-11-17 8:20 ` Ming Lei
2021-11-17 15:43 ` Jens Axboe
2021-11-17 20:48 ` Keith Busch
2021-11-17 23:59 ` Ming Lei
2021-11-17 20:41 ` Keith Busch
2021-11-18 0:18 ` Ming Lei
2021-11-18 2:02 ` Keith Busch
2021-11-18 2:14 ` Ming Lei
2021-11-17 3:38 ` [PATCH 2/4] nvme: split command copy into a helper Jens Axboe
2021-11-17 6:15 ` Christoph Hellwig
2021-11-17 15:44 ` Jens Axboe
2021-11-18 7:54 ` Chaitanya Kulkarni
2021-11-17 3:38 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
2021-11-17 6:17 ` Christoph Hellwig [this message]
2021-11-17 15:45 ` Jens Axboe
2021-11-18 7:59 ` Chaitanya Kulkarni
2021-11-17 3:38 ` [PATCH 4/4] nvme: add support for mq_ops->queue_rqs() Jens Axboe
2021-11-17 8:39 ` Christoph Hellwig
2021-11-17 15:55 ` Jens Axboe
2021-11-17 15:58 ` Jens Axboe
2021-11-17 19:41 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2021-12-03 21:45 [PATCHSET v2 0/4] Add support for list issue Jens Axboe
2021-12-03 21:45 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
2021-12-04 10:45 ` Hannes Reinecke
2021-12-16 16:05 [PATCHSET v4 0/4] Add support for list issue Jens Axboe
2021-12-16 16:05 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
2021-12-16 16:38 [PATCHSET v5 0/4] Add support for list issue Jens Axboe
2021-12-16 16:39 ` [PATCH 3/4] nvme: separate command prep and issue Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZSedy1bGe30XEHW@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).