public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] FAT: use blkdev_issue_flush() instead of congestion_wait()
Date: Wed, 17 Nov 2021 02:52:21 -0800	[thread overview]
Message-ID: <YZTe5Vl+ZiAHOK8y@infradead.org> (raw)
In-Reply-To: <163712349419.13692.2859038330142282757@noble.neil.brown.name>

On Wed, Nov 17, 2021 at 03:31:34PM +1100, NeilBrown wrote:
> 
> congestion_wait() in this context is just a sleep - block devices do not
> in general support congestion signalling any more.
> 
> The goal here is to wait for any recently written data to get to
> storage.  This can be achieved using blkdev_issue_flush().

This goes back to commit ae78bf9c4f5fde3c67e2829505f195d7347ce3e4
and looking at that this seems to be correct.  It might be worth to
reference that commit, though.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2021-11-17 10:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  4:31 [PATCH] FAT: use blkdev_issue_flush() instead of congestion_wait() NeilBrown
2021-11-17 10:52 ` Christoph Hellwig [this message]
2021-11-21  9:17 ` OGAWA Hirofumi
2021-11-22  0:51   ` NeilBrown
2021-11-22  5:29     ` OGAWA Hirofumi
2021-12-10  4:21       ` NeilBrown
2021-12-10  4:22         ` [PATCH v2] FAT: use schedule_timeout_uninterruptible() " NeilBrown
2021-12-11  8:27           ` OGAWA Hirofumi
2021-12-13  2:28             ` NeilBrown
2021-12-13  2:45               ` OGAWA Hirofumi
2021-12-13  2:49                 ` NeilBrown
2021-12-13  3:17                 ` [PATCH v3] FAT: use io_schedule_timeout() " NeilBrown
2021-12-11  8:16         ` [PATCH] FAT: use blkdev_issue_flush() " OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZTe5Vl+ZiAHOK8y@infradead.org \
    --to=hch@infradead.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox