From: Eric Biggers <ebiggers@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mmc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 2/3] block: don't delete queue kobject before its children
Date: Thu, 9 Dec 2021 15:17:35 -0800 [thread overview]
Message-ID: <YbKOj3lBEdJLE8mr@sol.localdomain> (raw)
In-Reply-To: <2a029611-10da-9114-b66b-345a68a5bd36@acm.org>
On Thu, Dec 09, 2021 at 02:38:02PM -0800, Bart Van Assche wrote:
> On 12/7/21 5:35 PM, Eric Biggers wrote:
> > + /* Now that all child objects were deleted, the queue can be deleted. */
>
> Shouldn't the present tense be used above (were -> are)? Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
"deleted" is an action here, not a state. I think it's fine as-is, but maybe
you would prefer the following?
/* Now that we've deleted all child objects, we can delete the queue. */
- Eric
next prev parent reply other threads:[~2021-12-09 23:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:35 [PATCH v3 0/3] block: show crypto capabilities in sysfs Eric Biggers
2021-12-08 1:35 ` [PATCH v3 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2021-12-09 19:00 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 2/3] block: don't delete queue kobject before its children Eric Biggers
2021-12-09 22:38 ` Bart Van Assche
2021-12-09 23:17 ` Eric Biggers [this message]
2021-12-09 23:26 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2021-12-09 22:51 ` Bart Van Assche
2021-12-09 23:40 ` Eric Biggers
2021-12-10 0:02 ` Bart Van Assche
2021-12-10 0:12 ` Eric Biggers
2021-12-10 6:42 ` Greg Kroah-Hartman
2021-12-10 17:29 ` Bart Van Assche
2021-12-10 17:45 ` Eric Biggers
2021-12-11 10:50 ` Greg Kroah-Hartman
2021-12-14 5:04 ` Bart Van Assche
2021-12-14 7:23 ` Chaitanya Kulkarni
2021-12-14 7:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbKOj3lBEdJLE8mr@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).