From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mmc@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs
Date: Sat, 11 Dec 2021 11:50:11 +0100 [thread overview]
Message-ID: <YbSCYyAv1SmYy7mz@kroah.com> (raw)
In-Reply-To: <cb29756b-8b21-5b4d-f107-b5573945d7ab@acm.org>
On Fri, Dec 10, 2021 at 09:29:41AM -0800, Bart Van Assche wrote:
> On 12/9/21 10:42 PM, Greg Kroah-Hartman wrote:
> > A single hex value makes sense to me.
>
> Hi Greg,
>
> I'm not enthusiast about this approach because:
> (a) A single hex value can be confused with a number. Reporting a bitfield in
> hex format is not sufficient to prevent confusion with a number.
Each sysfs file has their own "units" or values, or whatever. So a hex
number or bitfield or something else is fine.
Again, single value, no need to parse, is the key here.
> (b) No other block layer sysfs attribute follows this encoding scheme.
Then follow what they do. Do they have multiple values in a single
file? If so, they are broken and we should change that.
> (c) This encoding enforces the restriction that data unit sizes are a power of
> two. Is there anything fundamental in encryption that restricts data unit
> sizes to a power of two? I don't know the answer myself.
Again, you all can pick the rules you want for this file, if you want to
have bitfields, wonderful! If you want to make it an enum, wonderful!
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-11 10:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:35 [PATCH v3 0/3] block: show crypto capabilities in sysfs Eric Biggers
2021-12-08 1:35 ` [PATCH v3 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2021-12-09 19:00 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 2/3] block: don't delete queue kobject before its children Eric Biggers
2021-12-09 22:38 ` Bart Van Assche
2021-12-09 23:17 ` Eric Biggers
2021-12-09 23:26 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2021-12-09 22:51 ` Bart Van Assche
2021-12-09 23:40 ` Eric Biggers
2021-12-10 0:02 ` Bart Van Assche
2021-12-10 0:12 ` Eric Biggers
2021-12-10 6:42 ` Greg Kroah-Hartman
2021-12-10 17:29 ` Bart Van Assche
2021-12-10 17:45 ` Eric Biggers
2021-12-11 10:50 ` Greg Kroah-Hartman [this message]
2021-12-14 5:04 ` Bart Van Assche
2021-12-14 7:23 ` Chaitanya Kulkarni
2021-12-14 7:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbSCYyAv1SmYy7mz@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bvanassche@acm.org \
--cc=ebiggers@kernel.org \
--cc=hare@suse.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).