From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Laibin Qiu <qiulaibin@huawei.com>,
axboe@kernel.dk, yi.zhang@huawei.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] block/wbt: fix negative inflight counter when remove scsi device
Date: Tue, 14 Dec 2021 00:07:03 -0800 [thread overview]
Message-ID: <YbhQp9H6Z08izS+T@infradead.org> (raw)
In-Reply-To: <YbfvplNrBkuZUIyf@T590>
On Tue, Dec 14, 2021 at 09:13:10AM +0800, Ming Lei wrote:
> > Wouldn't it make more sense to simply not call wbt_enable_default from
> > elv_unregister_queue?
>
> wbt_disable_default() is called in bfq_init_root_group(), so wbt_enable_default
s/bfq_init_root_group/bfq_init_queue/
But yes, that sounds like an even better idea. Or maybe even an
elevator feature flag.
next prev parent reply other threads:[~2021-12-14 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 4:09 [PATCH -next] block/wbt: fix negative inflight counter when remove scsi device Laibin Qiu
2021-12-13 17:16 ` Christoph Hellwig
2021-12-14 1:13 ` Ming Lei
2021-12-14 8:07 ` Christoph Hellwig [this message]
2021-12-14 4:25 ` QiuLaibin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbhQp9H6Z08izS+T@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=qiulaibin@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).