From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
lining <lining2020x@163.com>, Tejun Heo <tj@kernel.org>,
Chunguang Xu <brookxu@tencent.com>
Subject: Re: [PATCH 1/2] block: add resubmit_bio_noacct()
Date: Mon, 10 Jan 2022 09:35:22 -0800 [thread overview]
Message-ID: <YdxuWlZAPJkPyr3h@infradead.org> (raw)
In-Reply-To: <20220110075141.389532-2-ming.lei@redhat.com>
On Mon, Jan 10, 2022 at 03:51:40PM +0800, Ming Lei wrote:
> Add block layer API of resubmit_bio_noacct() for handling blk-throttle
> iops limit correctly. Typical use case is that bio split, and it isn't
> good to export blk_throtl_charge_bio_split() for drivers, so add new API
> for serving such purpose.
Umm, submit_bio_noacct is meant exactly for this case of resubmitting
a bio. We should not need another API for that.
next prev parent reply other threads:[~2022-01-10 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 7:51 [PATCH 0/2] block/dm: add resubmit_bio_noacct for fixing iops throttling Ming Lei
2022-01-10 7:51 ` [PATCH 1/2] block: add resubmit_bio_noacct() Ming Lei
2022-01-10 17:35 ` Christoph Hellwig [this message]
2022-01-10 19:03 ` Mike Snitzer
2022-01-11 2:26 ` Ming Lei
2022-01-11 8:36 ` [dm-devel] " Christoph Hellwig
2022-01-11 1:56 ` Ming Lei
2022-01-11 8:42 ` [dm-devel] " Christoph Hellwig
2022-01-10 7:51 ` [PATCH 2/2] dm: use resubmit_bio_noacct to submit split bio Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdxuWlZAPJkPyr3h@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brookxu@tencent.com \
--cc=dm-devel@redhat.com \
--cc=lining2020x@163.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).